Fix StreamRefSerializer NRE bug #7333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Sep 4, 2024
| @@ -37,52 +36,51 @@ public sealed class StreamRefSerializer : SerializerWithStringManifest | |||
| public StreamRefSerializer(ExtendedActorSystem system) : base(system) | |||
| { | |||
| _system = system; | |||
| _serialization = system.Serialization; | |||
There was a problem hiding this comment.
This is the actual fix. system.Serialization is null if config were added before the ActorSystem is started because all serializer plugins were instantiated before ActorSystem.Serialization is assigned.
There was a problem hiding this comment.
This could make for a decent analyzer rule
| @@ -129,7 +127,7 @@ private SequencedOnNext DeserializeSequenceOnNext(byte[] bytes) | |||
| { | |||
| var onNext = Proto.Msg.SequencedOnNext.Parser.ParseFrom(bytes); | |||
| var p = onNext.Payload; | |||
| var payload = _serialization.Deserialize( | |||
| var payload = system.Serialization.Deserialize( | |||
There was a problem hiding this comment.
Actual fix. Instead of using a field assigned Serialization, we just retrieve it from _system.Serialization when we need it.
| @@ -169,7 +167,7 @@ private ByteString SerializeCumulativeDemand(CumulativeDemand demand) => | |||
| private ByteString SerializeSequencedOnNext(SequencedOnNext onNext) | |||
| { | |||
| var payload = onNext.Payload; | |||
| var serializer = _serialization.FindSerializerFor(payload); | |||
| var serializer = system.Serialization.FindSerializerFor(payload); | |||
There was a problem hiding this comment.
Actual fix. Instead of using a field assigned Serialization, we just retrieve it from _system.Serialization when we need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamRefSerializerwill throw an NRE ifActorMaterializer.DefaultConfig()were added to actor system configuration beforeActorSystemis started.Changes
Remove
_serializationfield from .ctor and use_system.Serializationinstead.