Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failure handling for BatchingSqlJournal SelectCurrentPersistenceIds message batching #5094

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Add failure handling for BatchingSqlJournal SelectCurrentPersistenceIds message batching #5094

merged 3 commits into from
Jun 15, 2021

Commits on Jun 15, 2021

  1. Add failure handling for BatchingSqlJournal SelectCurrentPersistenceI… 

    …ds message batching
    @Arkatufus
    Arkatufus committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    8167211 View commit details
    Browse the repository at this point in the history

  2. Do not throw an exception inside a failure handler, throwing will swa… 

    …llow the original failure cause, create a confusing error log, and blow up BatchingSqlJournal failure handling.
    @Arkatufus
    Arkatufus committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    08e3fed View commit details
    Browse the repository at this point in the history

  3. Add missing using to make sure reader is properly disposed

    @Arkatufus
    Arkatufus committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    6e3532c View commit details
    Browse the repository at this point in the history