Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denest tx #175

Merged
merged 6 commits into from
Apr 3, 2018
Merged

Denest tx #175

merged 6 commits into from
Apr 3, 2018

Conversation

aastein
Copy link
Contributor

@aastein aastein commented Apr 3, 2018

fixes #164

@aastein aastein requested a review from boz as a code owner April 3, 2018 19:45
@coveralls
Copy link

coveralls commented Apr 3, 2018

Pull Request Test Coverage Report for Build 237

  • 72 of 114 (63.16%) changed or added relevant lines in 12 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.07%) to 61.925%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/order/app.go 13 14 92.86%
cmd/akash/marketplace.go 0 5 0.0%
cmd/akash/deployment.go 0 6 0.0%
app/fulfillment/app.go 16 25 64.0%
app/lease/app.go 15 24 62.5%
cmd/akash/provider.go 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
app/order/app.go 1 52.11%
app/lease/app.go 1 24.1%
app/fulfillment/app.go 1 44.72%
cmd/akash/deployment.go 1 24.21%
Totals Coverage Status
Change from base Build 234: 0.07%
Covered Lines: 3152
Relevant Lines: 5090

💛 - Coveralls

Copy link
Contributor

@boz boz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aastein aastein merged commit baa56c6 into master Apr 3, 2018
@aastein aastein deleted the denest-tx branch April 3, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

de-nest transaction fields
3 participants