Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt flapping test fix #157

Merged
merged 1 commit into from
Mar 27, 2018
Merged

attempt flapping test fix #157

merged 1 commit into from
Mar 27, 2018

Conversation

aastein
Copy link
Contributor

@aastein aastein commented Mar 27, 2018

refs #124

The flapping test may be caused because close is called while the database is initializing.

@aastein aastein requested a review from boz as a code owner March 27, 2018 22:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 133

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.197%
Totals Coverage Status
Change from base Build 129: 0.0%
Covered Lines: 3147
Relevant Lines: 4754
💛 - Coveralls

boz
boz approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@boz boz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. let's try it. i'll back it out of the changes in #156

@aastein aastein merged commit 3335953 into master Mar 27, 2018
@aastein aastein deleted the flappingtest branch March 27, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boz boz boz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aastein @coveralls @boz