format cleanup: gofmt, golang-ci

* add & run `make gofmt` to format whole repo
* add goreportcard
* golang-ci: ignore comment issues

fixes #239
refs  #249

.golangci.yaml

@@ -0,0 +1,7 @@
+linters:
+  enable-all: true
+
+issues:
+  exclude:
+    - comment on exported (method|function|type|const|var)
+  exclude-use-default: true

.travis.yml

@@ -34,6 +34,16 @@ jobs:
         - make test-integration
         - make image-bins
 
+    # linux/1.10 (mainline): print linting errors
+    - name: test-lint
+      os: linux
+      go: "1.10"
+      allow_failures: true
+      script:
+        - make lintdeps-install
+        - make test-lint
+      if: type = cron
+
     # linux/master: tests, integration, image-bins
     - name: test
       os: linux
@@ -104,6 +114,7 @@ jobs:
 matrix:
   allow_failures:
     - env: TEST_UNSKIP=true
+    - name: test-lint
 
 cache:
   directories:

Makefile

@@ -46,6 +46,12 @@ test-full:
 test-cover:
 	goveralls -service=travis-ci -ignore="types/types.pb.go"
 
+test-lint:
+	golangci-lint run
+
+lintdeps-install:
+	go get -u github.com/golangci/golangci-lint/cmd/golangci-lint
+
 test-vet:
 	go vet $$(glide novendor | grep -v ./pkg/)
 
@@ -91,6 +97,10 @@ mocks:
 	mockery -case=underscore -dir provider/cluster  -output provider/cluster/mocks  -name Reservation
 	mockery -case=underscore -dir provider/manifest -output provider/manifest/mocks -name Handler
 
+gofmt:
+	find . -not -path './vendor*' -name '*.go' -type f | \
+		xargs gofmt -s -w
+
 docs:
 	(cd _docs/dot && make)
 
@@ -104,8 +114,10 @@ clean:
 	deps-install devdeps-install \
 	test-cover coverdeps-install \
 	test-integraion integrationdeps-install \
+	test-lint lintdeps-install \
 	test-vet \
 	mocks \
+	gofmt \
 	docs \
 	clean \
 	kubetypes

README.md

@@ -1,6 +1,7 @@
 [![Akash](_docs/img/logo-label-black.svg "Akash")](#overview)
 [![Build Status](https://travis-ci.org/ovrclk/akash.svg?branch=master)](https://travis-ci.org/ovrclk/akash)
 [![Coverage Status](https://coveralls.io/repos/github/ovrclk/akash/badge.svg?branch=master)](https://coveralls.io/github/ovrclk/akash?branch=master)
+[![Go Report Card](https://goreportcard.com/badge/github.com/ovrclk/akash)](https://goreportcard.com/report/github.com/ovrclk/akash)
 
 # Overview
 

app/account/app_test.go

@@ -35,7 +35,7 @@ func TestAccountApp(t *testing.T) {
 
 	_, cacheState := testutil.NewState(t, &types.Genesis{
 		Accounts: []types.Account{
-			types.Account{Address: addrfrom, Balance: balance},
+			{Address: addrfrom, Balance: balance},
 		},
 	})
 

app/app.go

@@ -204,7 +204,7 @@ func (app *app) DeliverTx(buf []byte) tmtypes.ResponseDeliverTx {
 		return tmtypes.ResponseDeliverTx{Code: code.INVALID_TRANSACTION, Log: err_.Error()}
 	}
 
-	// XXX: Accouts should be implicity created when tokens are sent to it
+	// XXX: Accouts should be implicitly created when tokens are sent to it
 	if signer == nil {
 		signer = &types.Account{
 			Address: ctx.Signer().Address().Bytes(),

app/store/app_test.go

@@ -44,8 +44,8 @@ func TestStoreApp(t *testing.T) {
 	{
 		key := append([]byte(pstate.AccountPath), fromaddr...)
 		resp := app.Query(state, tmtypes.RequestQuery{
-			Path:  store.QueryPath,
-			Data:  key,
+			Path: store.QueryPath,
+			Data: key,
 		})
 		acc := new(types.Account)
 		acc.Unmarshal(resp.Value)

cmd/akashd/init.go

@@ -89,7 +89,7 @@ func generateAkashGenesis(cmd *cobra.Command, args []string) (*ptypes.Genesis, e
 	}
 	return &ptypes.Genesis{
 		Accounts: []ptypes.Account{
-			ptypes.Account{Address: key.ID(), Balance: maxTokens},
+			{Address: key.ID(), Balance: maxTokens},
 		},
 	}, nil
 }

provider/event/bus.go

@@ -136,7 +136,7 @@ loop:
 			}
 
 			// Publish to children.
-			for sub, _ := range b.subscriptions {
+			for sub := range b.subscriptions {
 				sub.Publish(ev)
 			}
 
@@ -154,7 +154,7 @@ loop:
 		}
 	}
 
-	for sub, _ := range b.subscriptions {
+	for sub := range b.subscriptions {
 		sub.lc.ShutdownAsync(nil)
 	}
 

provider/manifest/http/server_test.go

@@ -68,5 +68,6 @@ func withServer(t *testing.T, fn func(), h *pmanifest.Handler) {
 	}()
 
 	testutil.SleepForThreadStart(t)
+
 	fn()
 }

sdl/v1.go

@@ -132,7 +132,7 @@ func (sdl *v1) DeploymentGroups() ([]*types.GroupSpec, error) {
 
 	// keep ordering stable
 	names := make([]string, 0, len(groups))
-	for name, _ := range groups {
+	for name := range groups {
 		names = append(names, name)
 	}
 	sort.Strings(names)
@@ -228,7 +228,7 @@ func (sdl *v1) Manifest() (*types.Manifest, error) {
 
 	// stable ordering
 	names := make([]string, 0, len(groups))
-	for name, _ := range groups {
+	for name := range groups {
 		names = append(names, name)
 	}
 	sort.Strings(names)