Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option for specifying Git revision to compare against #42

Closed
akaihola opened this issue Aug 7, 2020 · 0 comments · Fixed by #43
Closed

Option for specifying Git revision to compare against #42

akaihola opened this issue Aug 7, 2020 · 0 comments · Fixed by #43
Labels
enhancement New feature or request
Milestone
Darker 1.1.0

Comments

@akaihola
Copy link
Owner

akaihola commented Aug 7, 2020

Darker now always compares the working tree against Git HEAD to find out which lines were changed. It would be useful to allow comparisons against other revisions as well. One use case is to compare a feature branch to the branching point so formatting and linting fixes can be done before merging.

This could be implemented with a -r / --revision command line argument, defaulting to HEAD, and being used in darker.git.git_get_unmodified_content(). That function would include the revision when calling git show <revision>:/<path.py>.
@akaihola akaihola added the enhancement New feature or request label Aug 7, 2020
@akaihola akaihola added this to the 1.1.0 milestone Aug 7, 2020
akaihola added a commit that referenced this issue Aug 7, 2020
@akaihola
-r/--revision argument - what to compare to (#42)
f31b703
@akaihola akaihola mentioned this issue Aug 7, 2020
Merged
4 tasks
akaihola added a commit that referenced this issue Aug 7, 2020
@akaihola
-r/--revision argument - what to compare to (#42)
f47e907
akaihola added a commit that referenced this issue Aug 7, 2020
@akaihola
-r/--revision argument - what to compare to (#42)
b0bd353
akaihola added a commit that referenced this issue Aug 8, 2020
@akaihola
-r/--revision argument - what to compare to (#42)
a18dd4b
akaihola added a commit that referenced this issue Aug 8, 2020
@akaihola
-r/--revision argument - what to compare to (#42)
07d5364
akaihola added a commit that referenced this issue Aug 8, 2020
@akaihola
-r/--revision argument - what to compare to (#42)
f8a7d53
akaihola added a commit that referenced this issue Aug 8, 2020
@akaihola
-r/--revision argument - what to compare to (#42)
8486606
akaihola added a commit that referenced this issue Aug 8, 2020
@akaihola
-r/--revision argument - what to compare to (#42)
3c5e5ea
akaihola added a commit that referenced this issue Aug 8, 2020
@akaihola
-r/--revision argument - what to compare to (#42)
e5db30f
akaihola added a commit that referenced this issue Aug 9, 2020
@akaihola
-r/--revision argument - what to compare to (#42)
a018018
akaihola added a commit that referenced this issue Aug 10, 2020
@akaihola
-r/--revision argument - what to compare to (#42)
fccbdc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Darker 1.1.0
Development

Successfully merging a pull request may close this issue.

WIP: Add -r / --revision argument for specifying which Git revision to compare to akaihola/darker
1 participant
@akaihola