Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coerce whitespace strings correctly #2297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vwong
Copy link

@vwong vwong commented Jun 27, 2023

What issue does this pull request resolve?

Number/Integer strings with only whitespace gets coerced to 0, when it should be undefined

What changes did you make?

The code already skips coercion on empty zero-length strings, I refined this to skip coercion on strings that are empty after .trim().

Is there anything that requires more attention while reviewing?

No

@vwong
Copy link
Author

vwong commented Jun 28, 2023

The CI is broken, but I'm not sure what I would've done to cause it to break. Help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant