-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate dts generator for ace-code and ace-builds #5427
base: master
Are you sure you want to change the base?
Conversation
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
1 similar comment
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
3f9e279
to
ec775a3
Compare
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
ec775a3
to
b3db1c3
Compare
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
# Conflicts: # ace.d.ts
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Cool stuff! It seems that by automatically generating the declaration files, we're potentially adding stuff to our public contract (the |
I am removing all nodes marked as |
I have generated a list of newly exposed entities, which you can find here. This should help in deciding which ones to make private. Disclaimer: This comparison only includes entities within the Ace namespace. If whole class was missing in old |
@mkslanc there were some additions to the declaration files in the PRs merged lately, could you please rebase/merge and resolve conflicts? |
# Conflicts: # ace-internal.d.ts # ace.d.ts
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Done! + I improved filtering mechanism, now any node (function/property) marked with |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
# Conflicts: # ace.d.ts
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Issue #, if available: #4640
Description of changes:
This pull request introduces changes that enable the generation of a comprehensive TypeScript declaration file, designed to be utilized as a public API. These modifications ensure that the generated declaration file accurately reflects the structure of both
ace-builds
andace-code
packages, providing a seamless integration for developers.Key Features:
private
or@internal
in jsDoc comment) would be filtered from final declarationDisclaimer: For ace-builds, all internal module paths are modified to follow the
ace-builds-internal/module
structure, which could be used as completion items in IDE's.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.