-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add extra asset loaders #654
add extra asset loaders #654
Conversation
bfe6335
to
77ae8fc
Compare
Can you elaborate on a usecase? Why do you need multiple asset loaders for package localization? |
77ae8fc
to
3c352dd
Compare
Hi @bw-flagship This discussion: #592 and also here is another usecase: I have a package that uses the I know that I can add something like this with flutter_intl:
main_locale: en
enabled: true
class_name: MyPackageLocalization And add the ...
MaterialApp(
localizationsDelegates: [
...context.localizationDelegates,
MyPackageLocalization.delegate,
],
supportedLocales: context.supportedLocales,
... But, how can I do it with the |
@hamed-rezaee thanks for explaining! Some things prevent me from approving this pr in the current state:
|
@bw-flagship I will apply the suggested changes and update the PR asap. 👍🏻 |
41d4f2c
to
74f124b
Compare
Hey @bw-flagship this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good! Some minor findings
Add multi-asset loader to add more than one asset loader if it is needed, for example, if you want to add package localization to your project.