Update Zerolog integration for automatic linking of errors to routes #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-werdna
force-pushed
the
zerolog-update
branch
from
c5a8a87
to
c66f7d5
Compare
andrew-werdna
requested review from
chimanjain,
Hoggles,
mmcdaris,
Penthious and
thompiler
Penthious
approved these changes
Jul 18, 2022
…if present, move them from Notice.Params to Notice.Context type assert to string for both moved fields remove in-repo .gitignore in favor of putting these files in global .gitignore
andrew-werdna
force-pushed
the
zerolog-update
branch
from
a34c7ef
to
3df3cc3
Compare
chimanjain
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice.ParamstoNotice.Context@chimanjain I learned recently that if you put
route, andhttpMethodkeys on theNotice.Contextthen the Airbrake dashboard will automatically link reported errors to the route/method combination in one of the performance dashboards. Basically, we realized that as part of our integrations, we have been sending therouteandhttpMethodkeys on theNotice.Paramsby mistake. By moving these two key/values over to theNotice.Contextwe get the added benefit described above.