Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated changelog, notifier version #274

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

chimanjain
Copy link
Contributor

No description provided.

@chimanjain chimanjain requested a review from kyrylo May 9, 2022 12:27
@kyrylo
Copy link
Contributor

kyrylo commented May 9, 2022

Is this a release? We should update this only when we are about to release.

@chimanjain
Copy link
Contributor Author

Yes, we didn't update it when we release v5.5.0 and now it is showing v5.4.0 on dashboard.

@kyrylo
Copy link
Contributor

kyrylo commented May 9, 2022

Please make it clear in the commit message. Example commit: 841d8f8

@chimanjain
Copy link
Contributor Author

I will be updating the changelog in a separate commit.

@chimanjain chimanjain changed the title Update gobrake version in notifier Updated changelog, notifier version May 9, 2022
@chimanjain
Copy link
Contributor Author

PTAL

CHANGELOG.md Outdated

* Beego Status fix by @chimanjain in ([#264](https://github.com/airbrake/gobrake/pull/264))

* Fix readme link by @Penthious in ([#268](https://github.com/airbrake/gobrake/pull/268))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to mention by. That's just a distraction. As you can see, the rest of the changelog doesn't call any names.

@chimanjain chimanjain merged commit d3e09fe into master May 9, 2022
@chimanjain chimanjain deleted the fix-gobrake-version branch May 9, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants