Beego Status fix

[chimanjain]

When the response status is ok, the beego application sets it to 0. To fix that when we send the notice to airbrake, we overwrite the status to StatusOK i.e. 200

[kyrylo]

Please make the commit title more descriptive.

[kyrylo]

When the response status is ok, the beego application sets it to 0

Why is that so? Are you sure beego does it on purpose?

[chimanjain]

When the response status is ok, the beego application sets it to 0

Why is that so? Are you sure beego does it on purpose?

Not sure, I came across this issue when I was working on the cli integration.

[kyrylo]

We should probably investigate why it's like that. It's not normal that 0 is returned when 200 is meant. Therefore I am vary of merging this PR.

[chimanjain]

The default value of ctx.ResponseWriter.Status is 0, so when the programmer set it with Ctx.ResponseWriter.WriteHeader(), it gets set to that status code, otherwise it remains 0.
Generally, when we are returning the response of an api, we don't set the status when the response is ok, i.e. 200, so to overcome that, we overwrite the status to 200 if it was not set.

[kyrylo]

If beego leaves statusCode 0, then this if check will fail:

if response.StatusCode != http.StatusOK

Still hard to believe that 0 is intended. How do I replicate that scenario you mentioned in the original commit?

[kyrylo]

Example app by @chimanjain which shows the issue that is being fixed:

package main

import (
	"fmt"
	"net/http"
	"time"

	"github.com/beego/beego/v2/server/web/context"

	"github.com/beego/beego/v2/server/web"
)

type Date struct {
	Date int64 `json:"date"`
}

type Controller struct {
	web.Controller
}

func main() {
	ctrl := &Controller{}

	web.Router("/date", ctrl, "get:GetDate")
	web.Router("/datewithstatus", ctrl, "get:GetDateWithStatus")
	web.InsertFilterChain("/*", New())
	web.Run("127.0.0.1:3000")
}

func (ctrl *Controller) GetDate() {
	ctrl.JSONResp(&Date{Date: time.Now().Unix()})
}

func (ctrl *Controller) GetDateWithStatus() {
	ctrl.Ctx.ResponseWriter.WriteHeader(http.StatusOK)
	ctrl.JSONResp(&Date{Date: time.Now().Unix()})
}

func New() web.FilterChain {
	return func(next web.FilterFunc) web.FilterFunc {
		return func(ctx *context.Context) {

			next(ctx)
			fmt.Println(ctx.ResponseWriter.Status)

		}
	}
}

Airbrake API will reject the payload if statusCode is 0, therefore our best assumption is that the endpoint meant to return 200.

[kyrylo]

LGTM but please change the title of the PR and the commit title.

[kyrylo]

I can see that the commit title didn't change: d67b534

It says "bug fix". Hopefully, next time we can change that as well so that we have a clean git history.