Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: test against go1.13 #125

Merged
merged 2 commits into from
Jan 17, 2020
Merged

travis: test against go1.13 #125

merged 2 commits into from
Jan 17, 2020

Conversation

kyrylo
Copy link
Contributor

@kyrylo kyrylo commented Jan 16, 2020

go1.13 was released on 2019/09/03:
https://golang.org/doc/devel/release.html#go1.13

@vmihailenco
Copy link
Contributor

You also need to update golangci-lint to fix the build - https://github.com/airbrake/gobrake/blob/master/.travis.yml#L19

@kyrylo
Copy link
Contributor Author

kyrylo commented Jan 16, 2020

Bumped golangci-lint but this is still failing:
https://travis-ci.org/airbrake/gobrake/jobs/637831142

Copy link
Contributor

@vmihailenco vmihailenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a race that is there for some time - can be fixed separately

@kyrylo kyrylo merged commit 7e9411e into master Jan 17, 2020
@kyrylo kyrylo deleted the go-1-13-testing branch January 17, 2020 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants