Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[payload] Set status code on error rather than query status #19

Merged
merged 1 commit into from
Mar 7, 2018
Merged

[payload] Set status code on error rather than query status #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion superset/views/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,10 @@ def generate_json(self, datasource_type, datasource_id, form_data,
return json_error_response(utils.error_msg_from_exception(e))

status = 200
if payload.get('status') == QueryStatus.FAILED:
if (
payload.get('status') == QueryStatus.FAILED or
payload.get('error') is not None
):
status = 400

return json_success(viz_obj.json_dumps(payload), status=status)
Expand Down