[dashboard] fix save/save-as flow (apache#6350)

* [dashboard] fix save/save-as flow * [bugfix][dashboard] consistent response type for save/save-as
airbnb · Nov 9, 2018 · 8bf9a5b · 8bf9a5b
1 parent 5a37732
commit 8bf9a5b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/superset/assets/src/dashboard/actions/dashboardState.js b/superset/assets/src/dashboard/actions/dashboardState.js
@@ -132,7 +132,6 @@ export function saveDashboardRequest(data, id, saveType) {
     SupersetClient.post({
       endpoint: `/superset/${path}/${id}/`,
       postPayload: { data },
-      parseMethod: null,
     })
       .then(response =>
         Promise.all([

diff --git a/superset/views/core.py b/superset/views/core.py
@@ -1632,7 +1632,7 @@ def save_dash(self, dashboard_id):
         session.merge(dash)
         session.commit()
         session.close()
-        return 'SUCCESS'
+        return json_success(json.dumps({'status': 'SUCCESS'}))
 
     @staticmethod
     def _set_dash_metadata(dashboard, data):