Refactor the way how Payload headers are handled #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix flake8 |
kxepal
force-pushed
the
3035-refactor-payload-headers
branch
3 times, most recently
from
4548688
to
ba5bf63
Compare
Codecov Report
@@ Coverage Diff @@
## master #3479 +/- ##
==========================================
+ Coverage 97.91% 97.95% +0.04%
==========================================
Files 44 44
Lines 8567 8553 -14
Branches 1383 1377 -6
==========================================
- Hits 8388 8378 -10
+ Misses 74 71 -3
+ Partials 105 104 -1
Continue to review full report at Codecov.
|
asvetlov
reviewed
Jan 4, 2019
Yes, I'm trying to do this around the day, but getting distraction by various things. Once finish with them will remove WIP status. Stay tuned! |
kxepal
force-pushed
the
3035-refactor-payload-headers
branch
2 times, most recently
from
73194ac
to
0f71731
Compare
kxepal
changed the title
|
@asvetlov Ok, it's ready for review. |
kxepal
force-pushed
the
3035-refactor-payload-headers
branch
from
66ccd6e
to
74ad55e
Compare
|
Rebased with conflict fix. Also noticed that Travis CI and AppVeyor has different opinion about |
This change actually solves three separated, but heavy coupled issues: 1. `Payload.content_type` may conflict with `Payload.headers[CONTENT_TYPE]`. While in the end priority goes to the former one, it seems quite strange that Payload object may have dual state about what content type it contains. 2.IOPayload respects Content-Disposition which comes with headers. 3. ClientRequest.skip_autoheaders now filters Payload.headers as well. This issue was eventually found due to refactoring: Payload object may setup some autoheaders, but those will bypass skip logic.
On Linux it detects py-file as `text/x-python`, but on Windows CI just as `text/plain`.
asvetlov
approved these changes
Jan 5, 2019
asvetlov
pushed a commit
that referenced
this pull request
Jan 5, 2019
* Refactor the way how Payload headers are handled This change actually solves three separated, but heavy coupled issues: 1. `Payload.content_type` may conflict with `Payload.headers[CONTENT_TYPE]`. While in the end priority goes to the former one, it seems quite strange that Payload object may have dual state about what content type it contains. 2.IOPayload respects Content-Disposition which comes with headers. 3. ClientRequest.skip_autoheaders now filters Payload.headers as well. This issue was eventually found due to refactoring: Payload object may setup some autoheaders, but those will bypass skip logic. * Update change notes * Set Content-Type explicitly to avoid guessing issues On Linux it detects py-file as `text/x-python`, but on Windows CI just as `text/plain`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change actually solves three separated, but heavy coupled
issues:
Payload.content_typemay conflict withPayload.headers[CONTENT_TYPE].While in the end priority goes to the former one, it seems quite strange that
Payload object may have dual state about what content type it contains.
This is part of #3035 issue.
This issue was eventually found due to refactoring: Payload object
may setup some autoheaders, but those will bypass skip logic.