New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mypy to latest version and support mypy --strict #3927

Closed

AMDmi3 opened this issue Jul 22, 2019 · 1 comment

Contributor

AMDmi3 commented Jul 22, 2019

Long story short

Following discussion in #3868, here's an issue to track a progress of cleaning up errors reported by newer mypy and/or mypy in strict mode.

Expected behaviour

aiohttp is clean with latest mypy (0.720 ATOW) in --strict mode.

Actual behaviour

There are some errors after updating mypy, and a lot of errors after enabling strict mode.

Steps to reproduce

Run mypy --strict aiohttp with latest mypy

Your environment

FreeBSD 12.0 amd64, python 3.7, mypy 0.720

The text was updated successfully, but these errors were encountered:

Contributor Author

AMDmi3 commented Jul 22, 2019

(I'll try to fix at least a part of this)

AMDmi3 mentioned this issue

Fails mypy --strict because of reexports #3868

Closed

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Update mypy version to 0.720 (aio-libs#3927)

ab87b76

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix mypy 'Redundant cast' (aio-libs#3927)

5e9e631

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix mypy 'unused comment' (aio-libs#3927)

42e4043

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in rfc822_formatted_time (aio-libs#3927)

eb57de2

- Add type annotations to global variables
- Fix handling of unused return values from time.gmtime
- Silence mypy error on return line (it's not yet capable of deducing
  that _cached_formatted_datetime is always defined at the end of the
  function)

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Add assertion to fix mypy error (aio-libs#3927)

0f5e934

(MatchObject.lastindex may be None)

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in ClientSession ctor (aio-libs#3927)

e4b0b3c

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in ClientRequest ctor (aio-libs#3927)

16c4ba1

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in StreamResponse ctor (aio-libs#3927)

da56619

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy on awaits (aio-libs#3927)

7cd0296

    error: Incompatible types in "await" (actual type "Generator[Any, None, AbstractServer]", expected type "Awaitable[Any]")

Not sure how to fix, may be a typeshed problem

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy error in AccessLogger.log (aio-libs#3927)

13b7309

Not sure how to fix this properly, the logic is hard to follow

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy error in AbstractRoute ctor (aio-libs#3927)

a7eeaad

- Don't reuse variable to decomplicate logic
- Silence error at return line as mypy cannot deduce that result
  cannot be Awaitable after the 'if'

AMDmi3 mentioned this issue

Typing updates #3928

Closed

5 tasks

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in ClientRequest ctor (aio-libs#3927)

9be7933

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in StreamResponse ctor (aio-libs#3927)

e97186b

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy on awaits (aio-libs#3927)

e7737f4

    error: Incompatible types in "await" (actual type "Generator[Any, None, AbstractServer]", expected type "Awaitable[Any]")

Not sure how to fix, may be a typeshed problem

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy error in AccessLogger.log (aio-libs#3927)

a1feb09

Not sure how to fix this properly, the logic is hard to follow

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy error in AbstractRoute ctor (aio-libs#3927)

69784b4

- Don't reuse variable to decomplicate logic
- Silence error at return line as mypy cannot deduce that result
  cannot be Awaitable after the 'if'

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Update mypy version to 0.720 (aio-libs#3927)

9f0e2b1

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix mypy 'Redundant cast' (aio-libs#3927)

a9264ca

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix mypy 'unused comment' (aio-libs#3927)

610a616

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in rfc822_formatted_time (aio-libs#3927)

cfebf79

- Add type annotations to global variables
- Fix handling of unused return values from time.gmtime
- Silence mypy error on return line (it's not yet capable of deducing
  that _cached_formatted_datetime is always defined at the end of the
  function)

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Add assertion to fix mypy error (aio-libs#3927)

aa8c804

(MatchObject.lastindex may be None)

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in ClientSession ctor (aio-libs#3927)

4ec1a9a

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in ClientRequest ctor (aio-libs#3927)

09efc6c

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in StreamResponse ctor (aio-libs#3927)

9f91779

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy on awaits (aio-libs#3927)

ed94bc8

    error: Incompatible types in "await" (actual type "Generator[Any, None, AbstractServer]", expected type "Awaitable[Any]")

Not sure how to fix, may be a typeshed problem

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy error in AccessLogger.log (aio-libs#3927)

585f4af

Not sure how to fix this properly, the logic is hard to follow

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Update mypy version to 0.720 (aio-libs#3927)

2de08d7

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix mypy 'Redundant cast' (aio-libs#3927)

158f694

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix mypy 'unused comment' (aio-libs#3927)

ea60565

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in rfc822_formatted_time (aio-libs#3927)

6e9bc7f

- Add type annotations to global variables
- Fix handling of unused return values from time.gmtime
- Silence mypy error on return line (it's not yet capable of deducing
  that _cached_formatted_datetime is always defined at the end of the
  function)

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Add assertion to fix mypy error (aio-libs#3927)

7e38008

(MatchObject.lastindex may be None)

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in ClientSession ctor (aio-libs#3927)

3156f06

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in ClientRequest ctor (aio-libs#3927)

3256c5c

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in StreamResponse ctor (aio-libs#3927)

ba6aaf3

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy on awaits (aio-libs#3927)

87a87df

    error: Incompatible types in "await" (actual type "Generator[Any, None, AbstractServer]", expected type "Awaitable[Any]")

Not sure how to fix, may be a typeshed problem

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy error in AccessLogger.log (aio-libs#3927)

fc8bc51

Not sure how to fix this properly, the logic is hard to follow

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in ClientSession ctor (aio-libs#3927)

b72e105

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in ClientRequest ctor (aio-libs#3927)

a30edcc

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in StreamResponse ctor (aio-libs#3927)

d5f003b

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy on awaits (aio-libs#3927)

    error: Incompatible types in "await" (actual type "Generator[Any, None, AbstractServer]", expected type "Awaitable[Any]")

Not sure how to fix, may be a typeshed problem

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy error in AccessLogger.log (aio-libs#3927)

40851ff

Not sure how to fix this properly, the logic is hard to follow

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Fix typing in StreamResponse ctor (aio-libs#3927)

2d9486e

...by moving field type annotation to class definition

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy on awaits (aio-libs#3927)

a5e99e0

    error: Incompatible types in "await" (actual type "Generator[Any, None, AbstractServer]", expected type "Awaitable[Any]")

Not sure how to fix, may be a typeshed problem

AMDmi3 added a commit to AMDmi3/aiohttp that referenced this issue


          Silence mypy error in AccessLogger.log (aio-libs#3927)

f5d0a52

Not sure how to fix this properly, the logic is hard to follow

derlih mentioned this issue

Enforce strict mypy checks #5370

Merged

5 tasks

derlih mentioned this issue

[3.8] Enforce strict mypy checks #5425

Merged

5 tasks

derlih closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment