Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

628 bugfix #1145

Merged
merged 4 commits into from
Aug 22, 2023
Merged

628 bugfix #1145

merged 4 commits into from
Aug 22, 2023

Conversation

kasyanovse
Copy link
Collaborator

No description provided.

@kasyanovse kasyanovse linked an issue Aug 16, 2023 that may be closed by this pull request
multi_target_levels_forecasting is not working #628
Closed
@codecov
Copy link

codecov bot commented Aug 16, 2023 •
edited
Loading

Codecov Report

Merging #1145 (9b9b1cc) into master (0eb258b) will decrease coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1145      +/-   ##
==========================================
- Coverage   78.48%   78.46%   -0.03%     
==========================================
  Files         130      130              
  Lines        9323     9323              
==========================================
- Hits         7317     7315       -2     
- Misses       2006     2008       +2

see 1 file with indirect coverage changes

valer1435
valer1435 reviewed Aug 16, 2023
View reviewed changes
cases/multi_target_levels_forecasting.py
@@ -99,5 +100,5 @@ def run_multi_output_case(path, vis=False):


if __name__ == '__main__':
path_file = './data/lena_levels/multi_sample.csv'
path_file = fedot_project_root() / 'cases/data/lena_levels/multi_sample.csv'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В первый раз вижу такую запись пути. Обычно использовали Path.path для этого

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fedot_project_root() возвращает pathlib.Path. К нему таким образом можно присоединять пути.

А что за Path.path?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fedot_project_root() возвращает pathlib.Path. К нему таким образом можно присоединять пути.

А что за Path.path?

Перепутал с pathlib.Path

@aim-pep8-bot
Copy link

aim-pep8-bot commented Aug 17, 2023 •
edited
Loading

Hello @kasyanovse! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-08-17 12:37:47 UTC

@kasyanovse kasyanovse mentioned this pull request Aug 22, 2023
Open
4 tasks
@kasyanovse kasyanovse merged commit 8cb0468 into master Aug 22, 2023
6 checks passed
@kasyanovse kasyanovse deleted the 628-bugfix branch August 22, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valer1435 valer1435 valer1435 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multi_target_levels_forecasting is not working
3 participants
@kasyanovse @aim-pep8-bot @valer1435