Various fixes to work with large datasets in better way #1019

nicl-nno · 2023-01-11T17:01:07Z

There are several mini-fixes are applied:

Stopping if even one fold failed
Presets bug fixed
More stable wor for short timeouts
Various minor changes
Sequatial mode without Joblib parallelization
Tuner timeouts processing

codecov · 2023-01-11T22:24:08Z

Codecov Report

Merging #1019 (3fff7d4) into master (03ae732) will decrease coverage by 0.13%.
The diff coverage is 72.22%.

❗ Current head 3fff7d4 differs from pull request most recent head 4c6ebb4. Consider uploading reports for the commit 4c6ebb4 to get more accurate results

@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
- Coverage   87.88%   87.75%   -0.13%     
==========================================
  Files         206      206              
  Lines       13805    13849      +44     
==========================================
+ Hits        12132    12153      +21     
- Misses       1673     1696      +23

Impacted Files	Coverage Δ
fedot/core/pipelines/tuning/tuner_builder.py	`97.18% <ø> (ø)`
.../core/optimisers/opt_history_objects/individual.py	`81.41% <20.00%> (-2.85%)`	⬇️
fedot/core/optimisers/gp_comp/evaluation.py	`94.01% <33.33%> (-3.48%)`	⬇️
fedot/core/composer/composer_builder.py	`90.74% <50.00%> (-0.77%)`	⬇️
.../core/optimisers/archive/individuals_containers.py	`90.00% <50.00%> (-1.18%)`	⬇️
fedot/core/composer/gp_composer/gp_composer.py	`86.95% <55.55%> (-7.92%)`	⬇️
fedot/core/pipelines/tuning/unified.py	`90.00% <72.41%> (-10.00%)`	⬇️
fedot/api/main.py	`81.12% <75.00%> (-0.23%)`	⬇️
fedot/api/api_utils/api_composer.py	`97.79% <100.00%> (+0.03%)`	⬆️
...t/api/api_utils/assumptions/assumptions_handler.py	`86.00% <100.00%> (+0.58%)`	⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fedot/api/api_utils/api_composer.py

valer1435 · 2023-01-13T08:06:10Z

fedot/api/main.py

@@ -171,7 +171,10 @@ def fit(self,
        self.data_processor.accept_and_apply_recommendations(self.train_data, recommendations)
        self.params.accept_and_apply_recommendations(self.train_data, recommendations)
        self._init_remote_if_necessary()
-        self.params.update_available_operations_by_preset(self.train_data)
+
+        if self.params.api_params['preset'] != 'auto':


Почему потребовалось добавать условие?

Потому что сейчас если задать список available_operations вначале - то потом в варианте auto они уже не меняются. Не нашел блоее изящного решения, так кажется более масштабный рефакторинг нужен.

Сейчас получается, что работа с available_operations происходит тут и в этом куске кода. Так и должно быть?

fedot/api/api_utils/assumptions/assumptions_handler.py

valer1435 · 2023-01-20T08:42:23Z

fedot/api/main.py

@@ -171,7 +171,10 @@ def fit(self,
        self.data_processor.accept_and_apply_recommendations(self.train_data, recommendations)
        self.params.accept_and_apply_recommendations(self.train_data, recommendations)
        self._init_remote_if_necessary()
-        self.params.update_available_operations_by_preset(self.train_data)
+
+        if self.params.api_params['preset'] != 'auto':


Сейчас получается, что работа с available_operations происходит тут и в этом куске кода. Так и должно быть?

valer1435 · 2023-01-20T09:16:30Z

fedot/core/pipelines/tuning/unified.py

+
+            trials = Trials()
+
+            remaining_time = self.max_seconds - global_tuner_timer.minutes_from_start * 60


Почему нельзя считать секунды и надо округлять до минут?

Поменял.

gkirgizov · 2023-01-20T10:15:11Z

fedot/api/main.py

@@ -183,6 +190,9 @@ def fit(self,
            self.current_pipeline, self.best_models, self.history = \
                self.api_composer.obtain_model(**self.params.api_params)

+            if self.current_pipeline is None:
+                raise ValueError('No any models were found')


грамматика: достаточно "No models were found", c any масло масляное немного

Поменял

gkirgizov · 2023-01-20T10:19:40Z

fedot/core/optimisers/archive/individuals_containers.py

+        if not population:
+            return


сюда может придти None?

Может прийти [], если ни один индивид в популяции не успел обработаться.

fedot/core/optimisers/gp_comp/evaluation.py

fedot/core/pipelines/tuning/unified.py

YamLyubov · 2023-01-20T12:24:39Z

fedot/api/main.py

@@ -183,6 +190,9 @@ def fit(self,
            self.current_pipeline, self.best_models, self.history = \
                self.api_composer.obtain_model(**self.params.api_params)

+            if self.current_pipeline is None:
+                raise ValueError('No any models were found')


Здесь можно просто 'No models were found'.

Поменял.

nicl-nno · 2023-01-23T11:10:56Z

Обновил до мастера.

nicl-nno · 2023-01-23T11:18:38Z

Сейчас получается, что работа с available_operations происходит тут и в этом куске кода. Так и должно быть?

Если они явно не заданы - то вроде да.

nicl-nno added the in progress task in progress label Jan 11, 2023

valer1435 reviewed Jan 13, 2023

View reviewed changes

nicl-nno force-pushed the logger-imp branch from add96de to 538be7b Compare January 13, 2023 09:16

nicl-nno requested review from gkirgizov and YamLyubov January 19, 2023 16:59

valer1435 reviewed Jan 20, 2023

View reviewed changes

gkirgizov requested changes Jan 20, 2023

View reviewed changes

YamLyubov reviewed Jan 20, 2023

View reviewed changes

gkirgizov approved these changes Jan 23, 2023

View reviewed changes

nicl-nno added 3 commits January 23, 2023 13:14

Large data fixes

282b5f7

Code review fixes

e6d24ef

Code review fixes 2

66628d1

nicl-nno force-pushed the logger-imp branch from 18f7fc6 to 66628d1 Compare January 23, 2023 10:14

Test fix

4c6ebb4

nicl-nno requested review from valer1435 and YamLyubov January 23, 2023 11:10

valer1435 approved these changes Jan 23, 2023

View reviewed changes

YamLyubov approved these changes Jan 24, 2023

View reviewed changes

YamLyubov mentioned this pull request Jan 24, 2023

Add tuners aimclub/GOLEM#21

Merged

nicl-nno merged commit 3deb3e3 into master Jan 24, 2023

nicl-nno deleted the logger-imp branch January 27, 2023 21:25

MorrisNein mentioned this pull request Mar 29, 2023

Add more advanced API examples #1076

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various fixes to work with large datasets in better way #1019

Various fixes to work with large datasets in better way #1019

nicl-nno commented Jan 11, 2023 •

edited

Loading

codecov bot commented Jan 11, 2023 •

edited

Loading

valer1435 Jan 13, 2023

nicl-nno Jan 13, 2023

valer1435 Jan 13, 2023

valer1435 Jan 20, 2023

valer1435 Jan 20, 2023

valer1435 Jan 20, 2023

nicl-nno Jan 23, 2023

gkirgizov Jan 20, 2023

nicl-nno Jan 23, 2023

gkirgizov Jan 20, 2023

nicl-nno Jan 20, 2023

YamLyubov Jan 20, 2023

nicl-nno Jan 20, 2023

nicl-nno commented Jan 23, 2023

nicl-nno commented Jan 23, 2023


		trials = Trials()

		remaining_time = self.max_seconds - global_tuner_timer.minutes_from_start * 60

Various fixes to work with large datasets in better way #1019

Various fixes to work with large datasets in better way #1019

Conversation

nicl-nno commented Jan 11, 2023 • edited Loading

codecov bot commented Jan 11, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicl-nno commented Jan 23, 2023

nicl-nno commented Jan 23, 2023

nicl-nno commented Jan 11, 2023 •

edited

Loading

codecov bot commented Jan 11, 2023 •

edited

Loading