Commits on Sep 9, 2024

1. fix edenfs windows build and add CI for it …

   one of my previous GCC 13+ fixes broke windows build internally which geneivive was kind enough to fix, but I couldn't see it in OSS as github didn't have a windows build so I've added CI for it.
   
   I found a few other problems with windows cmake build along the way. Here are the build fixes and the CI to show they work.
   
     * upgrade ninja to fix problem finding make_fbpy_archive.py on windows VS build tools 2019 & 2022
   
     * upgrade libsodium to a version with VS 2019 binaries.
   
     * patch lmdb to build with cmake on windows as its makefile is not windows compatible
   
   Test plan:
   
   for make_fbpy_archive.py: test locally in the git base window with: python build/fbcode_builder/getdeps.py build --clean python-six`
   
   Before: `ninja: error: 'C:/Users/alex/local/sapling/build/fbcode_builder/CMake/make_fbpy_archive.py', needed by 'python-six.lib_install/python-six.manifest', missing and no known rule to make it`
   
   After, works
   
   for libsodium upgrade: test locally with: python build/fbcode_builder/getdeps.py build fizz
   
   Before, fails on not finding VS 2019 compatible libsodium
   
   After, works
   
   For lmdb cmake windows build: test locally with: python build/fbcode_builder/getdeps.py build lmdb
   
   
   
   add eden fs windows build
   
   make it visible if this builds is breaking

   

   ahornby committed Sep 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for dfee92a
   • Browse repository at this point

   Copy the full SHA

   dfee92a View commit details

   Browse the repository at this point in the history

2. getdeps: fix confusing slash when patching on windows

   

   ahornby committed Sep 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 51a4785
   • Browse repository at this point

   Copy the full SHA

   51a4785 View commit details

   Browse the repository at this point in the history