Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid HTML causes crash #20

Closed
FR0ST1N opened this issue Oct 25, 2021 · 3 comments
Closed

Invalid HTML causes crash #20

FR0ST1N opened this issue Oct 25, 2021 · 3 comments
Milestone
v0.0.0-apha.3

Comments

@FR0ST1N
Copy link
Contributor

FR0ST1N commented Oct 25, 2021

Problem

Editing inside the html content without the table element causes crash.

Video

2021-10-25.11-38-20.mp4
@FR0ST1N
Copy link
Contributor Author

FR0ST1N commented Oct 26, 2021

Update:

Causes error even when special characters are present when typing a new element.

Examples:

  • <td?
  • <p!

@aghontpi aghontpi added this to the v0.0.0-apha.3 milestone Oct 28, 2021
@aghontpi
Copy link
Owner

I believe, this can be achieved with DomParser.

  • initiate a global DomParser object for content mod
  • before pushing the updates and rendering to screen, test it with DomParser.
    • proceed if there are no errors
    • do nothing and wait for user input if there are errors

@aghontpi aghontpi changed the title HTML causes crash Invalid HTML causes crash Oct 30, 2021
aghontpi added a commit that referenced this issue Oct 30, 2021
@aghontpi
validate user html content before processing,
6bb6654 
fix: Invalid HTML causes crash, #20
@aghontpi
Copy link
Owner

6bb6654 fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.0.0-apha.3
Development

No branches or pull requests
2 participants
@FR0ST1N @aghontpi