Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP support 3.12 #459

Closed
wants to merge 8 commits into from
Closed

WIP support 3.12 #459

wants to merge 8 commits into from

Conversation

SiQube
Copy link
Member

@SiQube SiQube commented Jul 7, 2023

Description

Please include a clear and concise description of the change and which issue is fixed.
Please also include excepted improvements, relevant motivation and context.
List any dependencies that are required for this change.

Fixes issue #

Implemented changes

Insert a description of the changes implemented in the pull request.

  • Change 1
  • Change 2
  • Change 3

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change is or requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74996cd) 100.00% compared to head (f657376) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #459   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         2388      2387    -1     
  Branches       599       599           
=========================================
- Hits          2388      2387    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SiQube SiQube closed this Jul 7, 2023
@dkrako dkrako reopened this Aug 18, 2023
@dkrako
Copy link
Contributor

dkrako commented Aug 18, 2023

I see,

@dkrako dkrako closed this Aug 18, 2023
@dkrako dkrako reopened this Oct 10, 2023
@SiQube
Copy link
Member Author

SiQube commented Oct 10, 2023

fails because of apache/arrow#37880

@dkrako
Copy link
Contributor

dkrako commented Nov 7, 2023

tests fail during import pandas as pd:

E   AttributeError: partially initialized module 'pandas' has no attribute '_pandas_datetime_CAPI' (most likely due to a circular import)

the error message and stack trace is not that helpful

@SiQube
Copy link
Member Author

SiQube commented Nov 9, 2023

I'll fix it on the 20th.

@SiQube SiQube force-pushed the py312 branch 2 times, most recently from 3560516 to 77729a3 Compare December 3, 2023 16:13
@SiQube
Copy link
Member Author

SiQube commented Dec 3, 2023

this PR is currently lost -- will check on it later

@SiQube SiQube closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants