Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road to v3 #33

Draft
wants to merge 139 commits into
base: develop
Choose a base branch
from
Draft

Road to v3 #33

wants to merge 139 commits into from

Conversation

cshawaus
Copy link
Member

@cshawaus cshawaus commented Aug 8, 2020

These changes are in conjunction to updates in the aem-design/aemdesign-aem-support#26 project.

What is covered:

  • Renamed Google Map references to Google Maps
  • Removed the analytics modules as they provided no benefit
  • Improved how descriptions are allowed to appear in some components
  • Fixed the order of clientlibs for the styleguide template
  • Created a new DLS template
  • Made several improvements to the Vue component model
  • Clean up all of the models to reduce duplication
  • Add new functionality and authoring capability to components such as Content Block, [Page, News, etc.] Details
  • Added ability to hide authoring parsys' to prevent spacing/whitespace issues that CSS cannot resolve but requires janky JavaScript
  • Component Info template replaced by toolbar action in Touch UI
  • Cleaned up all dialogs
  • AEM 6.5 support
  • Migrate to Sling models

cshawaus and others added 30 commits March 29, 2020 19:10
- Renamed ‘googlemap’ to ‘googlemaps’
- Updated Vue component to the latest version
- Fixed a compilation issue with Cloud Config pages
To make it easier to extend, this change changes the visibility level of `getCloudConfigurations` to public which allows it to be overriden at the client level.
# Conflicts:
#	aemdesign-aem-common/src/main/content/jcr_root/apps/aemdesign/components/layout/parsys/parsys.jsp
This previous implementation causes issues where some CSS may be expecting a different element to be first which breaks it
The injection annotations don’t have to have worked for a while now and don’t do anything at runtime
This was designed to make generating format expressions far more simple, you can pass 1 field or as many as you’d like.

`getFormatExpression(“title”)`
- Added `isHasTitle` for detecting when the title is invalid
- Added `isUseContainer` to determine if the wrapping container should be used
- Added `isShowBreadcrumb` to determine if the breadcrumbs component needs to be available
- Added `isShowParsys` to determine if the authorable section of Page Details should be available
- Added `isParsysWithAuthoredContent` to determine if the authorable section of Page Details has content within it
The `TemplateSupport` model enables dynamic component paths to be generated using an invoked `Map` which automatically resolves the compoent path using `QueryBuilder`. This is the first draft of the implementation and dynamic tenant assignment via an OSGI configuration is not currently available.
This change was made to make it easier to extend and implement generic behaviours for invocator classes that may reuse some logic.
Up until now the expression requires to get the tenant (actually `namespace`) was complex and not extensible. This first pass introduces `${namespace}` which encapsulates the logic and allows for future updates by which the namespace can be 100% dynamic based on its context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants