Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update detail components #35

Open
5 tasks
cshawaus opened this issue Aug 8, 2020 · 0 comments
Open
5 tasks

Update detail components #35

cshawaus opened this issue Aug 8, 2020 · 0 comments
Assignees
@cshawaus
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Milestone
Road to v3 🚀

Comments

@cshawaus
Copy link
Member

cshawaus commented Aug 8, 2020

The current details components are useful but have some pitfalls that make authoring and developing with them somewhat painful in certain circumstances. All points below are designed to retain the same base components while improving performance and reducing duplication.

  • Ensure all models extend from GenericDetails
  • Move all shared logic from each individual model into GenericDetails
  • Remove all code that is non-essential to each individual model rendering to the page
  • Create a version of GenericDetails that doesn't rely on badge configuration for scenarios such as generating OG/meta tag in <head>
  • Create a method by which custom badge structures can be used by any details model

Further improvements to come!
@cshawaus cshawaus added this to the Road to v3 🚀 milestone Aug 8, 2020
@cshawaus cshawaus added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Aug 8, 2020
@cshawaus cshawaus self-assigned this Aug 8, 2020
cshawaus added a commit that referenced this issue Aug 10, 2020
@cshawaus
#35 - Minor optimisations to the details components
4495e3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cshawaus cshawaus

Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
Road to v3 🚀
Development

No branches or pull requests
1 participant
@cshawaus