Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable refurb rules in ruff #637

Closed

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

[FURB105]: Replace `print("")` with `print()`
[FURB124]: Replace `x == y and z == y` with `x == y == z`
@coveralls
Copy link

Coverage Status

coverage: 99.822%. remained the same
when pulling 5fe1827 on DimitriPapadopoulos:refurb
into d20aa6d on adrienverge:master.

@adrienverge
Copy link
Owner

adrienverge commented Jan 9, 2024

I'm not of than of these rules. Sometimes it helps readability to be able to write what refurb dislikes.

@DimitriPapadopoulos
Copy link
Contributor Author

Agreed. Some of the rules do improve code and performance, other rules may result in less readable code, such as:

if ...:
    return ....
return ....

instead of:

if ...:
    return ....
else:
    return ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants