Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add GitLab CI / Code Climate example #631

Merged
merged 8 commits into from
Jan 13, 2024

Conversation

gardar
Copy link
Contributor

@gardar gardar commented Jan 5, 2024

Perhaps better to add this example to the docs rather than it getting lost in a issue comment #243 (comment)

Signed-off-by: gardar <gardar@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Jan 5, 2024

Coverage Status

coverage: 99.822%. remained the same
when pulling 9ab559a on gardar:docs/gitlab-ci-example
into 1d65ab6 on adrienverge:master.

Signed-off-by: gardar <gardar@users.noreply.github.com>
Copy link
Owner

@adrienverge adrienverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gardar, thanks for contributing. This new documentation looks good, please just see my few comments.

docs/integration.rst Outdated Show resolved Hide resolved
docs/integration.rst Outdated Show resolved Hide resolved
docs/integration.rst Outdated Show resolved Hide resolved
docs/integration.rst Outdated Show resolved Hide resolved
gardar and others added 4 commits January 8, 2024 12:54
Co-authored-by: Adrien Vergé <adrienverge@gmail.com>
Signed-off-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: gardar <gardar@users.noreply.github.com>
Signed-off-by: gardar <gardar@users.noreply.github.com>
Copy link
Owner

@adrienverge adrienverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two remarks before it's good to go.

docs/integration.rst Outdated Show resolved Hide resolved
docs/integration.rst Outdated Show resolved Hide resolved
docs/integration.rst Outdated Show resolved Hide resolved
gardar and others added 2 commits January 9, 2024 23:34
Co-authored-by: Adrien Vergé <adrienverge@gmail.com>
Signed-off-by: gardar <gardar@users.noreply.github.com>
Copy link
Owner

@adrienverge adrienverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gardar!

@adrienverge adrienverge merged commit 0d7ae7b into adrienverge:master Jan 13, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants