Bail out if not run as root #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actual root privileges are required in many places, depending on the OS: * On Linux, the 'noauth' option of pppd seems to require actual root privileges. Being a meber of the 'dip' group on Ubuntu is not sufficient. * On Linux, setting routes requires root privileges unless user has CAP_NET_ADMIN capability. * On FreeBSD, setting routes using 'route' requires root privileges.
|
Hmm... I would merge this, but travis-ci is stuck somehow, although the commit itself seems to have passed the required check |
|
ok, after updating the branch travis-ci ran through smoothly |
|
Not the first time travis is stuck. This seems to be happening often these days. |
|
I have seen it on my pull requests occasionally and there it helped to refresh the travis-ci web interface a couple of times. But I think this can do only the owner of each pull request. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual root privileges are required in many places, depending on the OS:
Fixes #373.