Support SAML authentication #1241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were taken from the original author and all changes unrelated to SAML were removed.
Rainer-Keller
force-pushed
the
master
branch
from
5ac02fb
to
4db8b39
Compare
|
|
I've extracted only the SAML feature from your branch for easier review. The configuration options for dns and route overwrite I did not adopt. These options may go in as a separate pull request. |
|
I will wait for this to be merged first |
Rainer-Keller
force-pushed
the
master
branch
from
4db8b39
to
0e9f255
Compare
Let's see how it goes... |
Rainer-Keller
force-pushed
the
master
branch
from
0e9f255
to
412e692
Compare
In the initial implementation there were still some issues that needed to be fixed. One main improvement is that the http server thread does not run the tunnel thread. Instead the http server is first shut down and then the tunnel is started as usual.
Fix compiler warnings about comparing signed with unsigned integers.
Rainer-Keller
force-pushed
the
master
branch
from
412e692
to
191099c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on #1219, but has everything unrelated to SAML removed and all the review issues fixed.