-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIndowsPb: gpg signature verification for ANT binary #3018
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7c6d880
gpg signature verification for ANT binary
Haroon-Khel 19023aa
fix conditional
Haroon-Khel 7e95341
Create gnupg dir when doesnt exist
steelhead31 b822ae8
Linter fix
steelhead31 1b6710c
Linter fix.
steelhead31 46a69a2
Linter fix
steelhead31 fe9afac
Tweak path to GPG tasks
steelhead31 c2587df
Linter Fix
steelhead31 69cf056
Merge branch 'master' into windows.gpg
karianna 26825ac
Test Regsvr without silent for vs2017
steelhead31 8bf6be9
Undo regsvr test
steelhead31 80c1784
Merge branch 'master' into windows.gpg
Haroon-Khel e3025bf
remove playbooks_dir variable
Haroon-Khel 7d7bcb5
change import to include
Haroon-Khel 64ae227
Merge branch 'master' into windows.gpg
Haroon-Khel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
...e/playbooks/AdoptOpenJDK_Windows_Playbook/roles/GPG_signature_verification/tasks/main.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
--- | ||
# These tasks can only run once cygwin is installed on the remote machine | ||
|
||
- name: Check if gnupg directory exists | ||
win_stat: | ||
path: 'C:\cygwin64\home\%USERNAME%\.gnupg' | ||
register: gnupg_check | ||
|
||
- name: Create gnupg directory with Cygwin ( if it doesnt exist ) | ||
win_shell: C:/cygwin64/bin/bash.exe -c "mkdir -p ~/.gnupg" | ||
when: (not gnupg_check.stat.exists) | ||
|
||
- name: Fix Permissions | ||
win_shell: C:/cygwin64/bin/bash.exe -c "chmod og-rwx ~/.gnupg" | ||
|
||
- name: Import GPG Key | ||
win_command: gpg --keyserver keyserver.ubuntu.com --recv-keys "{{ GPG_key }}" | ||
|
||
- name: Get signature file | ||
win_command: wget -q "{{ signature_link }}" -O sigfile | ||
|
||
- name: Verify binary | ||
win_command: gpg --verify sigfile {{ file_path }} | ||
|
||
- name: Remove gnupg directory with Cygwin ( when it didnt exist previously ) | ||
win_shell: C:/cygwin64/bin/bash.exe -c "rm -rf ~/.gnupg" | ||
when: (not gnupg_check.stat.exists) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ant is on 1.10.13 now - should we upgrade?