Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude java/lang/String/StringRepeat.java on windows32 with jdk17 #3002

Closed
sophia-guo opened this issue Oct 15, 2021 · 5 comments · Fixed by #3029
Closed

Exclude java/lang/String/StringRepeat.java on windows32 with jdk17 #3002

sophia-guo opened this issue Oct 15, 2021 · 5 comments · Fixed by #3029
Assignees

Comments

@sophia-guo
Copy link
Contributor

Test java/lang/String/StringRepeat.java failed on window32 with jdk17, which is a known bug https://bugs.openjdk.java.net/browse/JDK-8221400. Fixes in. However probably old 32-bit system was forgot. #1272 (comment)

In this case we'd like to exclude this test.

https://ci.adoptopenjdk.net/job/Test_openjdk17_hs_sanity.openjdk_x86-32_windows/93/testReport/

To exclude: adding one exclusion statements in https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk17.txt (it should belong to jdk_lang section, like just after Line 81 ).

java/lang/String/StringRepeat.java#id1 https://bugs.openjdk.java.net/browse/JDK-8221400 windows-x86

@julian55455
Copy link
Contributor

Hi @sophia-guo can I take this upon myself?

@julian55455
Copy link
Contributor

julian55455 commented Oct 15, 2021

Hi @sophia-guo @AdamBrousseau How do you come up with the exclusion statements? I wanna trace one for this issue

@smlambert
Copy link
Contributor

The format of a ProblemList file is:

path/to/failing/testclass fullUrlToIssueWhereTheFailureIsReported comma-separatedListOfPlatformsToExcludeOn

so in this issue, Sophia put the exclude line at the end of this issue description, repeating here for clarity:
java/lang/String/StringRepeat.java#id1 https://bugs.openjdk.java.net/browse/JDK-8221400 windows-x86

One should check whether this test is already excluded in the ProblemList file, if so, then the change is merely to add windows-x86 to the section of the exclude line for platforms to exclude on.

@LizyBbethy
Copy link
Contributor

@smlambert @sophia-guo can you assign me this issue?

@smlambert
Copy link
Contributor

Assigning @LizyBbethy as there is a PR. Will find different issue for @julian55455 to work on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment