Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm: upgrade several dependencies #786

Merged
merged 14 commits into from
Apr 18, 2023
Merged

npm: upgrade several dependencies #786

merged 14 commits into from
Apr 18, 2023

Conversation

gdams
Copy link
Member

@gdams gdams commented Mar 27, 2023

I've done a pass of the TRSS client and updated a few dependencies, the main ones that remain are (Highcharts (including removal of deprecated highstock) and the set of react-xxx packages

@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for eclipsefdn-adoptium-trss ready!

Name Link
🔨 Latest commit f4ebd00
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium-trss/deploys/643e92be5bb49b0008eadce8
😎 Deploy Preview https://deploy-preview-786--eclipsefdn-adoptium-trss.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@gdams gdams marked this pull request as draft March 27, 2023 10:12
@gdams gdams marked this pull request as ready for review April 6, 2023 08:31
@tellison
Copy link

tellison commented Apr 6, 2023

I see problems displaying the dashboard on this staging server with this patch.
Screenshot 2023-04-06 at 10 40 59

@gdams
Copy link
Member Author

gdams commented Apr 6, 2023

I see problems displaying the dashboard on this staging server with this patch.

works for me??

Screenshot 2023-04-06 at 11 57 39

@llxia
Copy link
Contributor

llxia commented Apr 6, 2023

Test Results columns are all N/A on the stage server

image

@karianna
Copy link
Contributor

@gdams Safe to merge now?

@llxia
Copy link
Contributor

llxia commented Apr 12, 2023

I would like to have some time to review this PR if possible as it contains lots of API changes due to npm upgrades. Thanks

@llxia
Copy link
Contributor

llxia commented Apr 14, 2023

@gdams Thanks for upgrading the npm dependencies. It is a lot of work. :)

I did notice a couple of errors:

TypeError: Cannot read properties of undefined (reading 'search')
    at n.value (ResultSummary.jsx:323:60)

I believe this.props.location.search changed. Since we use it in several places, they all need to be updated.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'params')
    at n.<anonymous> (Output.jsx:23:48)

@gdams
Copy link
Member Author

gdams commented Apr 17, 2023

@gdams Thanks for upgrading the npm dependencies. It is a lot of work. :)

I did notice a couple of errors:

TypeError: Cannot read properties of undefined (reading 'search')
    at n.value (ResultSummary.jsx:323:60)

I believe this.props.location.search changed. Since we use it in several places, they all need to be updated.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'params')
    at n.<anonymous> (Output.jsx:23:48)

good spots, I've fixed both of those issues

@llxia
Copy link
Contributor

llxia commented Apr 17, 2023

https://deploy-preview-786--eclipsefdn-adoptium-trss.netlify.app/output/test?id=643463f217052c6715301a90

TypeError: Cannot read properties of undefined (reading 'state')
    at Output.jsx:79:51

There are still some this.props.location.search errors:

https://deploy-preview-786--eclipsefdn-adoptium-trss.netlify.app/buildTreeView?parentId=6436ea8317052c671545244a

BuildTreeView.jsx:37 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'search')
    at n.<anonymous> (BuildTreeView.jsx:37:56)

https://deploy-preview-786--eclipsefdn-adoptium-trss.netlify.app/testPerPlatform?testId=6434641117052c6715301ad2

TypeError: Cannot read properties of undefined (reading 'search')
    at n.value (TestPerPlatform.jsx:80:58)

@gdams
Copy link
Member Author

gdams commented Apr 17, 2023

https://deploy-preview-786--eclipsefdn-adoptium-trss.netlify.app/output/test?id=643463f217052c6715301a90

TypeError: Cannot read properties of undefined (reading 'state')
    at Output.jsx:79:51

There are still some this.props.location.search errors:

https://deploy-preview-786--eclipsefdn-adoptium-trss.netlify.app/buildTreeView?parentId=6436ea8317052c671545244a

BuildTreeView.jsx:37 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'search')
    at n.<anonymous> (BuildTreeView.jsx:37:56)

https://deploy-preview-786--eclipsefdn-adoptium-trss.netlify.app/testPerPlatform?testId=6434641117052c6715301ad2

TypeError: Cannot read properties of undefined (reading 'search')
    at n.value (TestPerPlatform.jsx:80:58)

And so the saga continues 😂, I've made several further changes. Let me know if you can see any other obvious broken changes (if not let's get this merged and as (if) more broken pages appear then I'll refactor the pages accordingly)

@llxia
Copy link
Contributor

llxia commented Apr 17, 2023

all this.props.location.search are affected. We should do a search to ensure they are all fixed.

https://deploy-preview-786--eclipsefdn-adoptium-trss.netlify.app/deepHistory?testId=64383a8c17052c6715491859

TypeError: Cannot read properties of undefined (reading 'search')
    at n.value (DeepHistory.jsx:83:58)

https://deploy-preview-786--eclipsefdn-adoptium-trss.netlify.app/buildDetail?parentId=6431c1e917052c67151a179a

TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at hH (query.js:3:12)
    at TestBreadcrumb.jsx:39:53
    at TestBreadcrumb.jsx:50:54

@gdams
Copy link
Member Author

gdams commented Apr 18, 2023

@llxia I think I've got all the remaining gotchas

@llxia
Copy link
Contributor

llxia commented Apr 18, 2023

TRSS_Code_Sync jobs are disabled at Adoptium and IBM so that the PR will affect the TRSS production servers during the release. We can update the TRSS server code after the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants