use angle bracket syntax #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Feb 12, 2020
README.md
Outdated
| @@ -162,7 +162,7 @@ You can pass any custom pikaday option through the component like this | |||
|
|
|||
| ```handlebars | |||
| <label> | |||
| {{pikaday-input options=(hash numberOfMonths=2 disableWeekends=true disableDayFn=(action 'someAction'))}} | |||
| <PikadayInput @options={{hash numberOfMonths=2 disableWeekends=true disableDayFn={{action 'someAction'}}}}/> | |||
There was a problem hiding this comment.
I think we still need to use (action 'someAction') because it is a nested handlebars expression.
There was a problem hiding this comment.
Thanks for catching this 👍 update made! :)
ghost
suggested changes
Feb 12, 2020
ghost
added
the
documentation
ghost
reviewed
Feb 12, 2020
README.md
Outdated
| {{pikaday-input onOpen=(action 'doSomethingOnOpen') onClose=(action 'doSomethingOnClose') | ||
| onDraw=(action 'doSomethingOnDraw')}} | ||
| <PikadayInput @onOpen={{action 'doSomethingOnOpen'}} @onClose={{action 'doSomethingOnClose'}} | ||
| onDraw={{action 'doSomethingOnDraw'}}/> |
There was a problem hiding this comment.
Suggested change
| onDraw={{action 'doSomethingOnDraw'}}/> | |
| @onDraw={{action 'doSomethingOnDraw'}}/> |
There was a problem hiding this comment.
Woah, thanks for catching this! 👍
ghost
approved these changes
Feb 13, 2020
|
Grand, thanks again @The-Bionic! |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use Angle Bracket syntax