Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass allowFileAccess option to electron-devtools-installer #747

Merged
merged 1 commit into from
Mar 3, 2021
Merged

pass allowFileAccess option to electron-devtools-installer #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion forge/files/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ app.on('ready', async () => {
console.log('Failed to install Devtron: ', err);
}
try {
await installExtension(EMBER_INSPECTOR);
await installExtension(EMBER_INSPECTOR, {
loadExtensionOptions: { allowFileAccess: true },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be loadExtensionOptions: { allowFileAccess: true } or just { allowFileAccess: true }?

Copy link
Contributor Author

@evoactivity evoactivity Mar 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's needed. loadExtensionOptions is what electron-devtools-installer passes to the options argument of electron's loadExtension method, which is where the allowFileAccess option is now available.

});
} catch (err) {
console.log('Failed to install Ember Inspector: ', err);
}
Expand Down
4 changes: 3 additions & 1 deletion forge/files/tests/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ app.on('ready', async function onReady() {
console.log('Failed to install Devtron: ', err);
}
try {
await installExtension(EMBER_INSPECTOR);
await installExtension(EMBER_INSPECTOR, {
loadExtensionOptions: { allowFileAccess: true },
});
} catch (err) {
console.log('Failed to install Ember Inspector: ', err);
}
Expand Down