Skip to content

Commit

Permalink
Require node >= 14.17.5 (#1208)
Browse files Browse the repository at this point in the history
electron-forge requires node 14.17.5 and several other packages are requiring 14.x, so this hopefully makes us compatible.
  • Loading branch information
RobbieTheWagner committed Jul 28, 2022
1 parent 4b80454 commit c0a80bc
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 11 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,13 @@ on:
tags:
- v*


jobs:
lint:
name: Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
with:
node-version: 12.x
- run: yarn install --frozen-lockfile --network-timeout 100000

- name: 'Lint'
Expand All @@ -35,8 +32,6 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
with:
node-version: 12.x
- run: yarn install --frozen-lockfile --network-timeout 100000

- name: 'Basic Tests'
Expand All @@ -54,8 +49,6 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
with:
node-version: 12.x
- run: yarn install --frozen-lockfile --network-timeout 100000

- name: 'End-to-end Tests (${{ matrix.package-manager }})'
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Compatibility

* Ember.js v3.24 or above
* Ember CLI v3.24 or above
* Node.js v12 or above
* Node.js v14.17.5 or above

Documentation
------------------------------------------------------------------------------
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
"ember-cli-dependency-checker": ">= 3.1.0"
},
"engines": {
"node": "12.* || 14.* || >= 16"
"node": ">= 14.17.5 || >= 16"
},
"publishConfig": {
"registry": "https://registry.npmjs.org"
Expand Down Expand Up @@ -163,7 +163,7 @@
}
},
"volta": {
"node": "12.22.1",
"yarn": "1.22.10"
"node": "14.20.0",
"yarn": "1.22.19"
}
}

0 comments on commit c0a80bc

Please sign in to comment.