Update to latest layout-bin-packer #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lukemelia
commented
Sep 25, 2023
lukemelia
commented
- Update tests for reliability by rounding to the nearest integer in many cases
|
Note that this will allow consuming apps to eliminate an ember-cli-babel version deprecation. |
lukemelia
force-pushed
the
update-layout-bin-packer
branch
2 times, most recently
from
b1b9576
to
2845fb6
Compare
|
Also note that I marked the ember-release scenario as allowedToFail because this addon is not yet compatible with ember 5 |
gilest
reviewed
Sep 26, 2023
| @@ -11,7 +11,7 @@ concurrency: | |||
| cancel-in-progress: true | |||
|
|
|||
| env: | |||
| NODE_VERSION: 14 | |||
There was a problem hiding this comment.
We'll probably want to bump the Node version in the package.json file, too.
Might be better to do that in a separate PR that lands before this one (since that will be a breaking change).
There was a problem hiding this comment.
I made that change and split out a dedicated commit. I tried to land this in a separate branch and couldn't get things to build.
There was a problem hiding this comment.
That's fair. I'm comfortable with the changes in that case since we want to get back into support.
- Update tests for reliability by rounding to the nearest integer in many cases
lukemelia
force-pushed
the
update-layout-bin-packer
branch
from
2845fb6
to
b6996d5
Compare
lukemelia
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.