feat(data-cruncher): port queries to the data cruncher from RUM Explorer #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a minor release when merged. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/spacecat-shared-rum-api-client/src/functions/opportunities/high-organic-low-ctr.js
Fixed
Show fixed
Hide fixed
packages/spacecat-shared-rum-api-client/src/functions/opportunities/high-organic-low-ctr.js
Fixed
Show fixed
Hide fixed
packages/spacecat-shared-rum-api-client/src/functions/opportunities/high-organic-low-ctr.js
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the existing queries to the
data-cruncherfrom https://github.com/adobe/helix-website/Main idea behind the port is to use the same definitions for the metrics and concepts.
So far, this PR contains the ports for the following queries:
more ports will follow...
This PR uses a copied version of the
cruncher.jsfrom https://github.com/adobe/helix-website/ library. The plan is to extract thecruncher.jsinto a shared library soon, so that the way raw RUM data crunched is the same in all places.Thanks @karlpauls for the contributions! 💯