Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Allow CSS Code Hints in PHP #11751

Merged
merged 1 commit into from
Sep 29, 2015
Merged

Allow CSS Code Hints in PHP #11751

merged 1 commit into from
Sep 29, 2015

Conversation

sprintr
Copy link
Contributor

@sprintr sprintr commented Sep 27, 2015

Allow CSS Code Hints in style tags for PHP files. Fixes #11629

CC: @abose

@abose abose added this to the Release 1.5 milestone Sep 28, 2015
* @param {{editor:{CodeMirror}, pos:{ch:{string}, line:{number}}, token:{object}}} ctx
* @return {{tokenize:function, state:string, stateArg:string, context:Object}}
*/
function _getState(ctx) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename it like _getTokenState or _getLocalState? _getState seems too common to me.
Can you add an assert for ctx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getContextState makes more sense here.

@abose
Copy link
Contributor

abose commented Sep 28, 2015

Hi guys, As we will be releasing 1.5 by Thursday, this change has to be pulled in by Tuesday or we could push this to 1.6.

@sprintr
Copy link
Contributor Author

sprintr commented Sep 28, 2015

@abose Cool! Will push the changes in a while.

abose added a commit that referenced this pull request Sep 29, 2015
@abose abose merged commit 5f5579b into adobe:release Sep 29, 2015
@abose
Copy link
Contributor

abose commented Sep 29, 2015

Thanks @sprintr .
Verified, all unit tests passing. Merging 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants