This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Add grunt task to check for correct nls keys #11299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a lot of string deletions in this PR. Is that intended? |
|
Yes, these are intended. |
|
Thanks. Could you update the pr resolving merge conflicts? |
marcelgerber
force-pushed
the
marcel/grunt-nls-check
branch
from
bed3e71
to
aa03241
Compare
|
Ready. |
|
Merge conflicts again 😅 probably due to all language pr merges for 1.5. |
marcelgerber
force-pushed
the
marcel/grunt-nls-check
branch
2 times, most recently
from
9daee42
to
7bb6520
Compare
|
@abose It's mergeable again. |
| } | ||
| }); | ||
|
|
||
| if (encounteredErrors) { |
There was a problem hiding this comment.
Why not call done(encounteredErrors)?
marcelgerber
force-pushed
the
marcel/grunt-nls-check
branch
from
7bb6520
to
38e8ba0
Compare
abose
added a commit
that referenced
this pull request
Sep 17, 2015
Add grunt task to check for correct nls keys
|
Merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This grunt task checks that all nls keys referenced in a nls file are actually present in the root file, too.
This will help us spot typos and the like.
I've dropped all the keys removed from the root file, but still present in some nls files.