-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update modifiers impl to use Node api and suppress Compose lint warnings on forked components #947
Conversation
…on forked components
|
|
🚨 UI regression detected! Checkout the paparazzi-delta artifact.
|
…te-code-for--lint
@@ -33,12 +33,12 @@ | |||
<plurals name="spark_rating_with_comments_a11y" tools:ignore="UnusedQuantity"> | |||
<item quantity="one">Note de %1$.1f pour %2$d avis</item> | |||
<item quantity="other">Note de %1$.1f pour %2$d avis</item> | |||
<item quantity="many">Note de %1$.1f pour %2$d avis</item> | |||
<item quantity="many">Note de %1$.1f pour %2$d d’avis</item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about these additions of d'
and de
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I checked french plural rules and for the many category it should/must be present
spark/src/main/kotlin/com/adevinta/spark/tools/modifiers/TouchTarget.kt
Outdated
Show resolved
Hide resolved
spark/src/main/kotlin/com/adevinta/spark/tools/modifiers/TouchTarget.kt
Outdated
Show resolved
Hide resolved
…Target.kt Co-authored-by: Simon Marquis <simon.marquis@adevinta.com>
…Target.kt Co-authored-by: Simon Marquis <simon.marquis@adevinta.com>
📋 Changes
Make the following
sparkUsageOverlay
modifier to use the Modifier.Node api, the modifierminimumTouchTargetSize
to use the material one as it has been made public and suppress the coming warnings from the next version of compose lint for components that we forked🤔 Context
As said in #923 (comment) this PR aims to surface the changes required to upgrade to the next compose lint version
✅ Checklist
🗒️ Other info