Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix annotatedStringResource with args don't render annotation style #887

Merged
merged 2 commits into from
Jan 15, 2024
Merged

fix: Fix annotatedStringResource with args don't render annotation style #887

merged 2 commits into from
Jan 15, 2024

Conversation

kazaky
Copy link
Contributor

@kazaky kazaky commented Jan 11, 2024

…s#253

📋 Changes

🤔 Context

✅ Checklist

  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • If it includes design changes, please ask for a review spark-design GitHub team.

📸 Screenshots

🗒️ Other info

@kazaky kazaky marked this pull request as ready for review January 15, 2024 14:12
@soulcramer soulcramer linked an issue Jan 15, 2024 that may be closed by this pull request
[Fix] annotatedStringResource with args don't render annotation styles #253
Closed
@soulcramer soulcramer added this pull request to the merge queue Jan 15, 2024
Merged via the queue into main with commit 9d5cec5 Jan 15, 2024
5 checks passed
@soulcramer soulcramer deleted the fix_annotatedStringResource_not_rendering_anotation_style branch January 15, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulcramer soulcramer soulcramer approved these changes

@SimonMarquis SimonMarquis Awaiting requested review from SimonMarquis SimonMarquis is a code owner

Assignees

@kazaky kazaky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] annotatedStringResource with args don't render annotation styles
2 participants
@kazaky @soulcramer