Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Attempt to reduce letter spacing on callout typo #880

Merged
merged 7 commits into from
Feb 6, 2024
Merged

fix: Attempt to reduce letter spacing on callout typo #880

merged 7 commits into from
Feb 6, 2024

Conversation

soulcramer
Copy link
Contributor

@soulcramer soulcramer commented Jan 10, 2024 •
edited by kazaky
Loading

📋 Changes

Enforce the usages of the typo callout in button even if it's was already the right one used to avoid regressions on refactor and specify explicitly the 0.sp letter spacing on typo to ensure that it's the value used everywhere.

🤔 Context

It seems like the typo in buttons fro android are "bigger" so after looking into it I didn't found any clue if this was really the case or not so I'm explicitly configuring the typo in case the defaults are not what we want.

✅ Checklist

  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • If it includes design changes, please ask for a review spark-design GitHub team.

📸 Screenshots

Can be found in changed files

@soulcramer soulcramer added the Bug Bug to fix label Jan 10, 2024
@soulcramer soulcramer added this to the 2024 Q1 - Sprint 1 milestone Jan 10, 2024
@soulcramer soulcramer self-assigned this Jan 10, 2024
@soulcramer soulcramer mentioned this pull request Jan 12, 2024
Merged
3 tasks
kazaky
kazaky previously approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@kazaky kazaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

🚨 UI regression detected! Checkout the paparazzi-delta artifact.
If these changes are expected, you can either:

  • manually run the gradlew recordPaparazziRelease and commit the new golden images
  • or ask @spark-ui-bot paparazzi golden images in this PR

@soulcramer
Merge branch 'main' into typo
ddec534 
# Conflicts:
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.popover_PopoverScreenshot_test_popover.png
#	spark/src/main/kotlin/com/adevinta/spark/components/buttons/Button.kt
@soulcramer
Merge remote-tracking branch 'origin/main' into typo
8ae5d9d 
# Conflicts:
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.iconbutton_IconButtonScreenshot_test_large.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.iconbutton_IconButtonScreenshot_test_medium.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.iconbutton_IconButtonScreenshot_test_small.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.iconbutton_IconToggleButtonScreenshot_test_pill_large.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.iconbutton_IconToggleButtonScreenshot_test_pill_medium.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.iconbutton_IconToggleButtonScreenshot_test_pill_small.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.iconbutton_IconToggleButtonScreenshot_test_rounded_large.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.iconbutton_IconToggleButtonScreenshot_test_rounded_medium.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.iconbutton_IconToggleButtonScreenshot_test_rounded_small.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.iconbutton_IconToggleButtonScreenshot_test_square_large.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.iconbutton_IconToggleButtonScreenshot_test_square_medium.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.iconbutton_IconToggleButtonScreenshot_test_square_small.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_accent_rounded_border_false.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_accent_rounded_border_true.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_alert_rounded_border_false.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_alert_rounded_border_true.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_basic_rounded_border_false.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_basic_rounded_border_true.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_danger_rounded_border_false.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_danger_rounded_border_true.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_info_rounded_border_false.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_info_rounded_border_true.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_main_rounded_border_false.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_main_rounded_border_true.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_neutral_rounded_border_false.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_neutral_rounded_border_true.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_success_rounded_border_false.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_success_rounded_border_true.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_support_rounded_border_false.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark.progress_ProgressScreenshot_test_intent_support_rounded_border_true.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_tabs_fixedsizetabgroup_dark.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_tabs_fixedsizetabgroup_light.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_tabs_scrollabletabgroup_dark.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_tabs_scrollabletabgroup_light.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_tabs_tab_dark.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_tabs_tab_light.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_multilinetextfieldintents_dark.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_multilinetextfieldintents_light.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_multilinetextfieldintentsalert_dark.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_multilinetextfieldintentsalert_light.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_multilinetextfieldintentserror_dark.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_multilinetextfieldintentserror_light.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_multilinetextfieldintentssuccess_dark.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_multilinetextfieldintentssuccess_light.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_selecttextfieldintents_dark.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_selecttextfieldintents_light.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_selecttextfieldintentsalert_dark.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_selecttextfieldintentsalert_light.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_selecttextfieldintentserror_dark.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_selecttextfieldintentserror_light.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_selecttextfieldintentssuccess_dark.png
#	spark-screenshot-testing/src/test/snapshots/images/com.adevinta.spark_PreviewScreenshotTests_preview_tests_textfields_selecttextfieldintentssuccess_light.png
@soulcramer
update changes
0d4cb4e
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Job Summary for Gradle

👷 Build → 🧑‍🔬 Test → 🕵️ Lint :: build-test-lint
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
spark-android assembleRelease 8.6 ✅ Build Scan NOT_PUBLISHED
spark-android globalCiUnitTest verifyPaparazziRelease 8.6 ❌ Build Scan NOT_PUBLISHED

@soulcramer soulcramer merged commit 221f592 into main Feb 6, 2024
5 checks passed
@soulcramer soulcramer deleted the typo branch February 6, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazaky kazaky kazaky left review comments

@SimonMarquis SimonMarquis Awaiting requested review from SimonMarquis SimonMarquis is a code owner

Assignees

@soulcramer soulcramer

Labels
Bug Bug to fix
Projects
None yet
Milestone
2024 Q1 - Sprint 3
Development

Successfully merging this pull request may close these issues.
2 participants
@soulcramer @kazaky