Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Progressbar): Progressbar configurator #867

Merged
merged 3 commits into from
Jan 11, 2024
Merged

feat(Progressbar): Progressbar configurator #867

merged 3 commits into from
Jan 11, 2024

Conversation

kazaky
Copy link
Contributor

@kazaky kazaky commented Dec 20, 2023 •
edited
Loading

📋 Changes

Add Progressbar configurator
Add Progressbar Examples

🤔 Context

Required to be able to test the component

✅ Checklist

  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • If it includes design changes, please ask for a review spark-design GitHub team.

📸 Screenshots

image

🗒️ Other info

@kazaky kazaky marked this pull request as ready for review December 20, 2023 22:21
@kazaky kazaky added the CatalogApp Related to the demo app label Dec 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

🔣 PR title format

commit validation: failed!
please enter a commit message in the commitizen format.
commit "": "feat(Progressbar)  Progressbar configurator"
pattern: (?s)(build|ci|docs|feat|fix|perf|refactor|style|test|chore|revert|bump)(\(\S+\))?!?:( [^\n\r]+)((\n\n.*)|(\s*))?$

@kazaky kazaky added this to the Q4 - Sprint 6 milestone Dec 20, 2023
@kazaky kazaky linked an issue Dec 20, 2023 that may be closed by this pull request
Add Progressbar Configurator #865
Closed
@kazaky kazaky changed the title feat(Progressbar) Progressbar configurator feat(Progressbar): Progressbar configurator Jan 4, 2024
kazaky and others added 2 commits January 11, 2024 01:53
@kazaky
Fix PR comments
9ac607e
Merge remote-tracking branch 'origin/main' into progressbar_configurator
d0d4ff9 
# Conflicts:
#	catalog/src/main/kotlin/com/adevinta/spark/catalog/model/Components.kt
@kazaky kazaky merged commit 51166b5 into main Jan 11, 2024
8 checks passed
@kazaky kazaky deleted the progressbar_configurator branch January 11, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulcramer soulcramer soulcramer left review comments

@SimonMarquis SimonMarquis Awaiting requested review from SimonMarquis SimonMarquis is a code owner

Assignees

@kazaky kazaky

Labels
CatalogApp Related to the demo app
Projects
None yet
Milestone
2023 Q4 - Sprint 6
Development

Successfully merging this pull request may close these issues.

Add Progressbar Configurator
2 participants
@kazaky @soulcramer