feat: Add TextField addons api with premade addons #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soulcramer
requested review from
SimonMarquis,
kazaky and
a team
as code owners
kazaky
reviewed
Oct 11, 2023
catalog/src/main/kotlin/com/adevinta/spark/catalog/configurator/component/Component.kt
Outdated
Show resolved
Hide resolved
|
🚨 UI regression detected! Checkout the paparazzi-delta artifact.
|
|
@spark-ui-bot paparazzi golden images |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Add the following Addons:
ButtonIconIconButtonIconToggleButtonTextDropDown🤔 Context
These are very opinionated addons as there's no spec ready for them but can provided guidnace on how to create one for feature teams
Closes #591
✅ Checklist
📸 Screenshots
Will push them in a followup PR with updated documentations
🗒️ Other info
We still have to update the documentation, add examples and modify the configurator