feat: Add Datastore support to Catalog #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theobch
requested review from
soulcramer,
MarinaRomanova,
SimonMarquis,
kazaky and
a team
as code owners
SimonMarquis
reviewed
Aug 9, 2023
SimonMarquis
reviewed
Aug 9, 2023
.../kotlin/com/adevinta/spark/catalog/configurator/samples/textfields/TextFieldsConfigurator.kt
Outdated
Show resolved
Hide resolved
SimonMarquis
reviewed
Aug 9, 2023
...c/main/kotlin/com/adevinta/spark/catalog/configurator/samples/buttons/ButtonsConfigurator.kt
Outdated
Show resolved
Hide resolved
SimonMarquis
reviewed
Aug 9, 2023
...lin/com/adevinta/spark/catalog/datastore/buttonconfigurator/ButtonsConfiguratorProperties.kt
Outdated
Show resolved
Hide resolved
SimonMarquis
reviewed
Aug 9, 2023
...evinta/spark/catalog/datastore/buttonconfigurator/ButtonsConfiguratorPropertiesSerializer.kt
Outdated
Show resolved
Hide resolved
SimonMarquis
reviewed
Aug 9, 2023
catalog/src/main/kotlin/com/adevinta/spark/catalog/util/Enum.kt
Outdated
Show resolved
Hide resolved
theobch
changed the title
kazaky
reviewed
Aug 10, 2023
...c/main/kotlin/com/adevinta/spark/catalog/configurator/samples/buttons/ButtonsConfigurator.kt
Outdated
Show resolved
Hide resolved
added 7 commits
August 10, 2023 14:42
Change-Id: I9c41a93248136f5184527e1a308200b6911d6a44
Change-Id: Ie081359eb67db6b6f22f564726eb901c5226ce47
Change-Id: I0f06f5947d88ca34b85c35751816c838401fe4f8
Change-Id: I6e2c67d1877cbe119e0c37f3f88f6863fe820cee
Change-Id: I25955fb6cd7c121c42af2cbf1c4bd1ce8fd59ed2
Change-Id: Ia2761002d36de366dc6f2bb2d3358b2424705087
Change-Id: I4088a94aceb87eafcd296b1d62faba20e02757ab
|
@SimonMarquis sorry for the last force-push, kind f*ck hard my local branch. |
Change-Id: I25955fb6cd7c121c42af2cbf1c4bd1ce8fd59ed2
soulcramer
previously approved these changes
Aug 17, 2023
|
I'll check it again either this week if I have time or in 2 weeks sorry for the delay 🙇 |
# Conflicts: # catalog/src/main/kotlin/com/adevinta/spark/catalog/configurator/samples/buttons/ButtonsConfigurator.kt # catalog/src/main/kotlin/com/adevinta/spark/catalog/configurator/samples/textfields/TextFieldsConfigurator.kt # gradle/libs.versions.toml
# Conflicts: # catalog/src/main/kotlin/com/adevinta/spark/catalog/MainActivity.kt # gradle/libs.versions.toml
soulcramer
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes description
This P.R adresses #597
🤔 Context
Add Datastore support inside Catalog app, which allows Catalog State (Theme and *Configurator) to be saved.
✅ Checklist
spark-designGitHub team.📸 Screenshots
N/A
🗒️ Other info
Contributing has more information and tips for a great pull request.