New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not apply _showEndOfPage: false if more content is to come #168

Closed

oliverfoster opened this issue Aug 3, 2022 · 1 comment · Fixed by #169

Assignees

Labels

Member

oliverfoster commented Aug 3, 2022

Subject of the issue

When used with branching at the end of a page, with _showEndOfPage: false, trickle is currently unaware that more content will be added and therefore hides the trickle button thinking the branching block is the last in the page.

The text was updated successfully, but these errors were encountered:

oliverfoster self-assigned this

oliverfoster added the bug label

oliverfoster added a commit that referenced this issue


          Fix: _showEndOfPage is branching aware (fixes #168)

b66bbcf

oliverfoster mentioned this issue

Fix: _showEndOfPage is branching aware (fixes #168) #169

Merged

joe-allen-89 closed this as completed in #169

joe-allen-89 pushed a commit that referenced this issue


          Fix: _showEndOfPage is branching aware (fixes #168) (#169)

5262c9b

Fix: _showEndOfPage is branching aware (fixes #168) (#169)

github-actions bot pushed a commit that referenced this issue


          Chore(release): 6.3.4 [skip ci]

0dc1242

## [6.3.4](v6.3.3...v6.3.4) (2022-11-28)

### Fix

* _showEndOfPage is branching aware (fixes #168) (#169) ([5262c9b](5262c9b)), closes [#168](#168) [#169](#169) [#168](#168) [#169](#169)

github-actions bot commented Nov 28, 2022

🎉 This issue has been resolved in version 6.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot added the released label

github-actions bot pushed a commit to redwoodperforms/adapt-contrib-trickle that referenced this issue


          Chore(release): 6.0.0 [skip ci]

c601e3f

# [6.0.0](v5.2.3...v6.0.0) (2023-07-10)

### Breaking

* Replace @navigation-height with --adapt-navigation-height (fixes adaptlearning#187) ([0079d6e](0079d6e)), closes [adaptlearning#187](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/187)

### Fix

* _globals schema nesting (adaptlearning#186) ([a8e8c2a](a8e8c2a)), closes [adaptlearning#186](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/186)
* _showEndOfPage is branching aware (fixes adaptlearning#168) (adaptlearning#169) ([5262c9b](5262c9b)), closes [adaptlearning#168](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/168) [adaptlearning#169](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/169) [adaptlearning#168](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/168) [adaptlearning#169](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/169)
* Added gitignore for release automation (adaptlearning#167) ([5712f7b](5712f7b)), closes [adaptlearning#167](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/167)
* Added logging switch and do not applyLocks on completion reset when not reset (fixes adaptlearning#174) (adaptlearning#175) ([426c583](426c583)), closes [adaptlearning#174](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/174) [adaptlearning#175](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/175) [adaptlearning#174](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/174) [adaptlearning#175](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/175)
* Added missing logging import (adaptlearning#179) ([caced5e](caced5e)), closes [adaptlearning#179](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/179)
* Added position relative; to trickle btn (adaptlearning#171) ([0ea78af](0ea78af)), closes [adaptlearning#171](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/171)
* Added release automation (adaptlearning#166) ([46e9c3c](46e9c3c)), closes [adaptlearning#166](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/166)
* Amended `getModelContainer` to work with blocks (adaptlearning#181) ([21590d1](21590d1)), closes [adaptlearning#181](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/181) [adaptlearning#180](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/180) [adaptlearning#180](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/180)
* Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#182) ([6158527](6158527)), closes [adaptlearning#182](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/182)
* Normalizing template icons ([389a621](389a621))
* Scroll to nowhere (fixes 172) (adaptlearning#173) ([bc1cb81](bc1cb81)), closes [adaptlearning#173](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/173)
* Version numbers removed from Readme files ([fdc7637](fdc7637))

### New

* Added bottom navigation styling (adaptlearning#162) ([fe1f828](fe1f828)), closes [adaptlearning#162](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/162)
* Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) (adaptlearning#163) ([4dd1602](4dd1602)), closes [adaptlearning#163](https://github.com/redwoodperforms/adapt-contrib-trickle/issues/163)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment