Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/2915 Re-added Logger global reference for debug window #201

Merged
merged 1 commit into from
Sep 21, 2020
Merged

issue/2915 Re-added Logger global reference for debug window #201

merged 1 commit into from
Sep 21, 2020

Conversation

olivermartinfoster
Copy link
Contributor

@olivermartinfoster olivermartinfoster commented Sep 17, 2020 •
edited by moloko
Loading

Fixes #2915

Fixed

  • Global reference to Logger class

@olivermartinfoster olivermartinfoster self-assigned this Sep 17, 2020
tomgreenfield
tomgreenfield approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 26d9a73 into master Sep 21, 2020
@oliverfoster oliverfoster deleted the issue/2915 branch September 21, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomgreenfield tomgreenfield tomgreenfield approved these changes

@moloko moloko moloko approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@olivermartinfoster olivermartinfoster

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adapt-contrib-spoor: SCORM debug window no longer showing output
5 participants
@olivermartinfoster @tomgreenfield @moloko @cahirodoherty-learningpool @oliverfoster