Fix: Convert template to JSX (fixes #89)

[swashbuck]

Fixes #89

Fix

• Adds .jsx template and removes .hbs template
• Removes resources_force_download helper. The download HTML property is now widely supported: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#browser_compatibility Do we still need to support IE or older mobile OS versions?
• Moved helper functions to the .jsx template and removed the helper JS file. As far as I know, these functions were not used by any other plugins. So, they shouldn't need to be registered as Handlebars helpers that can be accessed outside this plugin.

[chris-steele]

In practice IE11 support has been dropped in most cases, but the framework and core plugin GH pages still state support for IE11, so I would assume that as a core plugin this one should continue to provide support. N.B. https://www.adaptlearning.org/index.php/documentation/ links to a spec which is very much out of date!

[chris-steele]

Great job @swashbuck, my only comment is that for a full conversion onFilterClicked should be incorporated into your React component.

[swashbuck]

Thanks, @chris-steele . I've moved the event to the template and added the resourcesForceDownload() helper since this needs to support IE11.

[swashbuck]

@chris-steele I seem to have a problem getting a11y.focusFirst to work. Should I be using a ref hook or am I not using a11y.focusFirst properly?

Aside from that, do you think it would be worthwhile to make a new React component type for each resources__filter-btn? That would reduce the amount of repeated code.

[chris-steele]

You could create a child component for the buttons 👍 you could also do one for the resource-item to reduce the complexity of this component (I would recommend it if the resource models were dynamic as it would reduce the number of React renders, but in this case resource models are static AFAIK)

[swashbuck]

You could create a child component for the buttons 👍 you could also do one for the resource-item to reduce the complexity of this component (I would recommend it if the resource models were dynamic as it would reduce the number of React renders, but in this case resource models are static AFAIK)

Thanks, @chris-steele ! Focus is now working. I'll work on creating the child components next.

[chris-steele]

@oliverfoster @cahirodoherty-learningpool @eleanor-heath @joe-allen-89 I'm hearing internally that we aren't supporting IE11 anymore in Adapt, can anyone weigh-in on this?

[cahirodoherty-learningpool]

@oliverfoster @cahirodoherty-learningpool @eleanor-heath @joe-allen-89 I'm hearing internally that we aren't supporting IE11 anymore in Adapt, can anyone weigh-in on this?

Hi Chris, yeah it's my understanding that we we no longer officially support IE11, but we can allow support of it as an override setting. I think anything IE specific can/should be dropped going forward.

[swashbuck]

I've created child components for the filter buttons and resource items.

I've also introduced a resourceTypes array that contains the filter categories. This should make it easier to add new categories if necessary. One of our clients likes to have several custom categories and doesn't use the default ones (document, link, media). This also reduces code repetition as the filter button component only appears once in the code.

[cahirodoherty-learningpool]

👀

[cahirodoherty-learningpool]

👀

[github-actions]

🎉 This PR is included in version 5.3.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀