Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added support for _canShowCorrectness #224

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

New: Added support for _canShowCorrectness #224

wants to merge 8 commits into from

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Sep 10, 2024 •
edited
Loading

part of adaptlearning/adapt_framework#3597

Allows option _canShowCorrectness instead of _canShowModelAnswer, to replace the associated toggle button and display correctness directly on the component.

image

New

  • Added support for _canShowCorrectness

requires
ref adaptlearning/adapt-contrib-core#582
ref adaptlearning/adapt-contrib-vanilla#527

@oliverfoster oliverfoster self-assigned this Sep 10, 2024
kirsty-hames
kirsty-hames approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected thanks. Please see comment raised regarding consistency of selector naming/nesting.

less/mcq.less Outdated Show resolved Hide resolved
kirsty-hames
kirsty-hames approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected thanks

joe-allen-89
joe-allen-89 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working and much nicer than toggle buttons 👍

@oliverfoster
Copy link
Member Author

Needs schemas, readme and example.json for _canShowCorrectness.

kirsty-hames

This comment was marked as resolved.

Sign in to view

@kirsty-hames

This comment was marked as resolved.

Sign in to view
@kirsty-hames
undo aria-disabled and raise as separate issue/pr
46c5a62 
...change isn't specific to _canShowModelAnswer functionality and will also apply to other question components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@joe-allen-89 joe-allen-89 Awaiting requested review from joe-allen-89

Assignees

@oliverfoster oliverfoster

Labels
enhancement
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverfoster @kirsty-hames @joe-allen-89