Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default for _imageAlignment for popup images #301

Closed
swashbuck opened this issue Mar 26, 2024 · 1 comment · Fixed by #302
Closed

Set default for _imageAlignment for popup images #301

swashbuck opened this issue Mar 26, 2024 · 1 comment · Fixed by #302
Assignees
@kirsty-hames
Labels
bug released

Comments

@swashbuck
Copy link
Contributor

Subject of the issue

Currently, the _imageAlignment property is required to be set in order for a popup image to appear. Can we default to _imageAlignment: "left" or something so that this doesn't break popup images?

https://github.com/adaptlearning/adapt-contrib-hotgraphic/blob/master/templates/hotgraphicPopup.jsx
@swashbuck swashbuck mentioned this issue Mar 26, 2024
Closed
@swashbuck swashbuck changed the title Set default for _imageAlignment Set default for _imageAlignment for popup images Mar 26, 2024
@kirsty-hames kirsty-hames self-assigned this Apr 24, 2024
@kirsty-hames kirsty-hames mentioned this issue Apr 24, 2024
Merged
joe-allen-89 pushed a commit that referenced this issue Apr 26, 2024
@kirsty-hames @oliverfoster
Fix: Set default for _imageAlignment for popup images (fixes #301) (#302
1f00c26 
)

* set default for _imageAlignment for popup images

* align _imageAlignment for popup images with schema defaults

schema defaults to 'right'

* refine _imageAlignment condition

Co-authored-by: Oliver Foster <oliver.foster@kineo.com>

* only apply _imageAlignment class if item has image

---------

Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
github-actions bot pushed a commit that referenced this issue Apr 26, 2024
@semantic-release-bot
Chore(release): 6.11.3 [skip ci]
11d0a12 
## [6.11.3](v6.11.2...v6.11.3) (2024-04-26)

### Fix

* Set default for _imageAlignment for popup images (fixes #301) (#302) ([1f00c26](1f00c26)), closes [#301](#301) [#302](#302)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 6.11.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
bug released
Projects
None yet
Milestone
No milestone
2 participants
@swashbuck @kirsty-hames