Error when using _isNarrativeOnMobile

[swashbuck]

Subject of the issue

When using _isNarrativeOnMobile: true and viewing on mobile, the following error is shown:

Uncaught (in promise) TypeError: parentChildViews is undefined
    replaceWithNarrative hotgraphicView.js:47

Note that this does not happen if first viewing on desktop and then switching to mobile. It only happens if you are viewing mobile when the page first loads.

Your environment

• Framework 5.31.11
• Hot Graphic 6.7.5
• Narrative 7.4.9

Steps to reproduce

1. Using a desktop browser, adjust screen width to mobile view (719px or narrower, assuming screenSize properties are default)
2. In a Hot Graphic, enable _isNarrativeOnMobile
3. Reload the page

Expected behaviour

No console errors

Actual behaviour

Console error!

Screenshots

[swashbuck]

Hi @oliverfoster . In the Hot Graphic view, I can prevent the error by changing this line:

adapt-contrib-hotgraphic/js/hotgraphicView.js

Line 46 in a4b949e

const parentChildViews = parentView.getChildViews();

To return an empty array:

const parentChildViews = parentView.getChildViews() || [];

However, I noticed that getChildViews() in adaptView.js will return 'undefined' if _childViews is not set.

https://github.com/adaptlearning/adapt-contrib-core/blob/1e73f329c21e6eb906c102db23f600666117cd74/js/views/adaptView.js#L397

if (!this._childViews) return this._childViews;

Should it return an empty array instead?

if (!this._childViews) return [];

Or is there a better way to handle this in general (ex. changing something in adapt-contrib-narrative)?

[kirsty-hames]

I can also replicate this issue testing on Mac Safari, Chrome and FF. Same conditions, open the browser at mobile screen width and increase the browser width above 719px.

In addition to the console error, multiple instances of Hotgraphic are rendered. The first instance of Hotgraphic displays the narrative slides rather than an image with pins.

[github-actions]

🎉 This issue has been resolved in version 6.7.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀